forked from electronicarts/CnC_Generals_Zero_Hour
-
Notifications
You must be signed in to change notification settings - Fork 78
[GEN][ZH] Fix game halting when left Alt key is pressed #837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorcerer86pt
approved these changes
May 10, 2025
xezon
reviewed
May 11, 2025
xezon
reviewed
May 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the way it should be fixed is like so:
switch( wParam )
{
case SC_MOVE:
case SC_SIZE:
case SC_MAXIMIZE:
case SC_MONITORPOWER:
if( FALSE == ApplicationIsWindowed )
return 1;
break;
case SC_KEYMENU:
return 1;
}
d83b11a
to
0dc277c
Compare
Did something similar to this but i stuck the SC_KEYMENU option first in the switch. |
xezon
approved these changes
May 11, 2025
xezon
reviewed
May 12, 2025
0dc277c
to
ce9f0de
Compare
Tweaked based on requests and also matched the indentation to match the surrounding code block. |
xezon
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the game from freezing when the left ALT key is pressed.
The underlying issue is due to the games window process not acknowledging the
WM_SYSCOMMAND SC_KEYMENU
message.Due to this, the message is then processed by the default window process which then will try to open the windows context menu which does not exist in this instance but causes the message loop to freeze.
This may also help prevent some mismatches that could be caused by a game freezing for too long when someone is playing in window mode.