-
Notifications
You must be signed in to change notification settings - Fork 40
Behind building text fix #2701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Behind building text fix #2701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Needs comment and yaml.
PL: "Za budynkami" | ||
US: "Show Units Behind Buildings" | ||
DE: "Einheiten hinter Gebäuden anzeigen" | ||
FR: "Afficher les unités derrière les bâtiments" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this text have enough room in the options menu?
RU: "Отображать Войска за зданиями" | ||
AR: "تﺎﻳﺎﻨﺒﻟا ﻒﻠﺧ" | ||
UK: "Показувати Підрозділи за будівлями" | ||
AR: "Show Units Behind Buildings" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest not change Arabic to English.
Fixed and ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
changes: | ||
- fix: Improves text in Behind building option string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- tweak: Improves the text of the behind buildings option for all languages.
No description provided.