Skip to content

Behind building text fix #2701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dmgreeny
Copy link
Collaborator

No description provided.

@dmgreeny dmgreeny added Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related labels Mar 20, 2025
Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Needs comment and yaml.

PL: "Za budynkami"
US: "Show Units Behind Buildings"
DE: "Einheiten hinter Gebäuden anzeigen"
FR: "Afficher les unités derrière les bâtiments"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this text have enough room in the options menu?

RU: "Отображать Войска за зданиями"
AR: "تﺎﻳﺎﻨﺒﻟا ﻒﻠﺧ"
UK: "Показувати Підрозділи за будівлями"
AR: "Show Units Behind Buildings"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest not change Arabic to English.

@dmgreeny
Copy link
Collaborator Author

Fixed and ready to merge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest merge the yaml of this change with the one of #2700, after #2700 has been merged, because both touch the Options menu.



changes:
- fix: Improves text in Behind building option string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • tweak: Improves the text of the behind buildings option for all languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants