Skip to content

Behind building text fix #2701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Behind building text fix #2701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcedc26
Update generals.str
dmgreeny Mar 20, 2025
0432b08
Update
dmgreeny Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions Patch104pZH/Design/Changes/v1.0/2701_Behind_building_line_fix.yaml
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest merge the yaml of this change with the one of #2700, after #2700 has been merged, because both touch the Options menu.

Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
---
date: 2025-03-27

title: Changes Behind building option string


changes:
- fix: Improves text in Behind building option string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • tweak: Improves the text of the behind buildings option for all languages.


subchanges:

labels:
- minor
- text
- v1.0

links:
- https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2701

authors:
- dmgreen
23 changes: 13 additions & 10 deletions Patch104pZH/GameFilesEdited/Data/generals.str
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41346,20 +41346,23 @@ AR: "Toggle showing shadows in game. Turn off for improved performance"
UK: "Увімкнути показ тіней у грі. Вимкніть для кращої продуктивності"
END

// Patch104p @fix dmgreen 27/03/2025 Changes US from "Behind Buildings" (#2701)
// Patch104p @fix dmgreen 27/03/2025 Changes DE, FR, ES, IT, KO, ZH, BP, PL strings to reflect US change (#2701)

// context: Checkbox on the Advance Display Options menu
GUI:BehindBuilding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this text have enough room in the options menu?

US: "Behind Buildings"
DE: "Hinter Gebäuden"
FR: "Transparence des bâtiments"
ES: "Tras los edificios"
IT: "Tracce di calore"
KO: "건물 후방 표시"
ZH: "建築物後方顯示"
BP: "Assinatura de Calor"
PL: "Za budynkami"
US: "Show Units Behind Buildings"
DE: "Einheiten hinter Gebäuden anzeigen"
FR: "Afficher les unités derrière les bâtiments"
ES: "Mostrar unidades detrás de los edificios"
IT: "Mostra unità dietro gli edifici"
KO: "건물 뒤에 있는 유닛 표시"
ZH: "顯示建築物後面的單位"
BP: "Mostrar unidades atrás dos edifícios"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest not change Arabic to English.

PL: "Pokaż jednostki za budynkami"
RU: "Отображать Войска за зданиями"
AR: "تﺎﻳﺎﻨﺒﻟا ﻒﻠﺧ"
UK: "Показувати Підрозділи за будівлями"
UK: "Показувати одиниці за будівлями"
END

// context: Checkbox on the Advance Display Options menu
Expand Down