Skip to content

[NU-2152] Missing parameters in node are only reported as warnings in logs - no validation error is returned #8019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 7, 2025
Merged

[NU-2152] Missing parameters in node are only reported as warnings in logs - no validation error is returned #8019

merged 7 commits into from
May 7, 2025

Conversation

arkadius
Copy link
Member

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added client client main fe docs ui labels Apr 30, 2025
@github-actions github-actions bot mentioned this pull request Apr 30, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 30, 2025 •
edited
Loading

updated: #8031
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@arkadius arkadius force-pushed the NU.2152.loose.missing.parameters.validation branch from eca6a21 to fc6b7d4 Compare April 30, 2025 16:59
@github-actions github-actions bot mentioned this pull request Apr 30, 2025
Closed
@arkadius arkadius changed the base branch from staging to NU.2152.loose.redundant.parameters.validation May 5, 2025 11:06
@github-actions github-actions bot mentioned this pull request May 5, 2025
Closed
@github-actions github-actions bot removed the docs label May 5, 2025
@arkadius arkadius changed the base branch from NU.2152.loose.redundant.parameters.validation to staging May 5, 2025 14:17
@arkadius arkadius force-pushed the NU.2152.loose.missing.parameters.validation branch from 706061a to 78a1e93 Compare May 5, 2025 16:01
@arkadius arkadius marked this pull request as ready for review May 6, 2025 14:38
@github-actions github-actions bot removed client client main fe ui labels May 6, 2025
@arkadius arkadius force-pushed the NU.2152.loose.missing.parameters.validation branch from f7d3f5c to 6db40f9 Compare May 6, 2025 16:06
@arkadius arkadius force-pushed the NU.2152.loose.missing.parameters.validation branch from 6db40f9 to 3f3ebe1 Compare May 7, 2025 09:13
@arkadius arkadius requested a review from mslabek May 7, 2025 09:15
@arkadius arkadius merged commit fa98628 into staging May 7, 2025
18 checks passed
@arkadius arkadius deleted the NU.2152.loose.missing.parameters.validation branch May 7, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mslabek mslabek mslabek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arkadius @mslabek