Conversation
|
I've been using these changes while working on updating mahi to build on 23.4.0. |
danmcd
left a comment
danmcd
left a comment
There was a problem hiding this comment.
LOVE all of the documentation and URL updates.
Please address not only the one inline comment, but also make sure you update the ticket with what you're doing here (incl. the documentation updates).
| function gitify(dir, repo) { | ||
| exec('git init', dir, function () { | ||
| exec('git remote add origin git@github.com:joyent/' + repo + '.git', | ||
| exec('git remote add origin https://github.com/TritonDataCenter/' + repo + '.git', |
There was a problem hiding this comment.
I think we should probably leave this as ssh here (and probably elsewhere in this PR?). I don't have my gh token set up for doing operations over HTTP, but my ssh key is always available.
| (mkdir -p $(BUILD) \ | ||
| && cd $(BUILD) \ | ||
| && [[ -d src-node ]] && (cd src-node && git checkout master && git pull) || git clone https://github.com/joyent/node.git src-node \ | ||
| && [[ -d src-node ]] && (cd src-node && git checkout master && git pull) || git clone https://github.com/nodejs/node.git src-node \ |
There was a problem hiding this comment.
I'm pretty sure that the branch here will need to be main. I had to fix that in the sdcnode repo. This also makes me wonder if this bit of code even ever gets used anymore...
3 participants
No description provided.