Skip to content

chore(pool): move MIN_INITIAL_DEPOSIT to constants.rs (#592) - #710

Closed
ZacLou wants to merge 2 commits into
TrusTrove:mainfrom
ZacLou:chore/move-min-deposit-1788623684
Closed

chore(pool): move MIN_INITIAL_DEPOSIT to constants.rs (#592)#710
ZacLou wants to merge 2 commits into
TrusTrove:mainfrom
ZacLou:chore/move-min-deposit-1788623684

Conversation

@ZacLou

@ZacLou ZacLou commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Closes #592

What

Moves the MIN_INITIAL_DEPOSIT constant from lib.rs to constants.rs, where other shared pool constants already live.

Changes

  • constants.rs: added pub const MIN_INITIAL_DEPOSIT: u128 = 10_000_000; with its existing doc comment.
  • lib.rs: removed the MIN_INITIAL_DEPOSIT definition (it remains available through pub use constants::*;).

Notes

  • No behavioural change — the constant is re-exported from constants.rs exactly as before.
  • cargo check -p pool should pass.

@ZacLou
ZacLou requested a review from K1NGD4VID as a code owner September 5, 2026 15:55
@mergekeeper

mergekeeper Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Needs review

Linked to #592, but the diff does not match the issue scope.

The pull request deletes almost the entire contents of contracts/pool/src/lib.rs, which goes far beyond moving the MIN_INITIAL_DEPOSIT constant.

Reviewed commit: 444152498e7b215e2aa17e93bc49e4bb5b07f922.

@ZacLou

ZacLou commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

Closing — rebase error deleted almost the entire lib.rs. Opening a clean replacement PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(pool): MIN_INITIAL_DEPOSIT constant lives in lib.rs instead of constants.rs

1 participant