chore(pool): move MIN_INITIAL_DEPOSIT to constants.rs (#592) - #710
Closed
ZacLou wants to merge 2 commits into
Closed
chore(pool): move MIN_INITIAL_DEPOSIT to constants.rs (#592)#710ZacLou wants to merge 2 commits into
ZacLou wants to merge 2 commits into
Conversation
Contributor
|
Needs review Linked to The pull request deletes almost the entire contents of contracts/pool/src/lib.rs, which goes far beyond moving the MIN_INITIAL_DEPOSIT constant. Reviewed commit: |
Contributor
Author
|
Closing — rebase error deleted almost the entire lib.rs. Opening a clean replacement PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #592
What
Moves the
MIN_INITIAL_DEPOSITconstant fromlib.rstoconstants.rs, where other shared pool constants already live.Changes
constants.rs: addedpub const MIN_INITIAL_DEPOSIT: u128 = 10_000_000;with its existing doc comment.lib.rs: removed theMIN_INITIAL_DEPOSITdefinition (it remains available throughpub use constants::*;).Notes
constants.rsexactly as before.cargo check -p poolshould pass.