Move packages #23135
Open
Move packages #23135
+115
−428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
""" WalkthroughThis change removes the standalone Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (23)
💤 Files with no reviewable changes (6)
✅ Files skipped from review due to trivial changes (14)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (12)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
ghost/core/core/shared/events/index.js (1)
15-23: Export new post-related events from shared index.
Theindex.jsnow includes exports forPostDeletedEventand all bulk post event classes. Confirm that each event file (e.g.,PostsBulkAddTagsEvent.js) defines a named export matching the property used here (.PostsBulkAddTagsEvent). If any module exports a default, adjust it to a named export for compatibility.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
.docker/Dockerfile(0 hunks)compose.yml(0 hunks)ghost/core/core/server/services/Users.js(1 hunks)ghost/core/core/server/services/posts/PostsService.js(1 hunks)ghost/core/core/shared/events/index.js(1 hunks)ghost/core/package.json(0 hunks)ghost/core/test/unit/shared/events/post-events.test.ts(1 hunks)ghost/post-events/.eslintrc.js(0 hunks)ghost/post-events/README.md(0 hunks)ghost/post-events/package.json(0 hunks)ghost/post-events/src/index.ts(0 hunks)ghost/post-events/test/.eslintrc.js(0 hunks)ghost/post-events/tsconfig.json(0 hunks)
💤 Files with no reviewable changes (9)
- ghost/post-events/README.md
- ghost/core/package.json
- .docker/Dockerfile
- ghost/post-events/tsconfig.json
- compose.yml
- ghost/post-events/test/.eslintrc.js
- ghost/post-events/.eslintrc.js
- ghost/post-events/package.json
- ghost/post-events/src/index.ts
🧰 Additional context used
🧬 Code Graph Analysis (3)
ghost/core/core/server/services/Users.js (1)
ghost/core/core/server/services/posts/PostsService.js (2)
require(2-2)require(8-15)
ghost/core/core/server/services/posts/PostsService.js (1)
ghost/core/core/server/services/Users.js (2)
require(8-8)require(10-10)
ghost/core/core/shared/events/index.js (10)
ghost/core/core/server/services/Users.js (2)
require(8-8)require(10-10)ghost/core/core/server/services/posts/PostsService.js (2)
require(2-2)require(8-15)ghost/core/core/frontend/services/sitemap/SiteMapManager.js (1)
require(2-2)ghost/core/core/server/services/VerificationTrigger.js (1)
require(3-3)ghost/core/core/server/services/members-events/EventStorage.js (1)
require(1-1)ghost/core/core/frontend/web/site.js (2)
require(5-5)require(19-19)ghost/core/core/server/services/comments/CommentsService.js (1)
require(3-3)ghost/core/core/server/services/staff/StaffService.js (1)
require(1-1)ghost/core/core/server/services/members-events/LastSeenAtUpdater.js (3)
require(1-1)require(3-3)require(4-4)ghost/core/core/server/services/url/Resources.js (1)
require(4-4)
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: Ghost-CLI tests
- GitHub Check: Unit tests (Node 22.13.1)
- GitHub Check: Regression tests (Node 20.11.1, sqlite3)
- GitHub Check: Unit tests (Node 20.11.1)
- GitHub Check: Database tests (Node 20.11.1, sqlite3)
- GitHub Check: Regression tests (Node 20.11.1, mysql8)
- GitHub Check: Database tests (Node 22.13.1, mysql8)
- GitHub Check: Database tests (Node 20.11.1, mysql8)
- GitHub Check: i18n
- GitHub Check: Lint
🔇 Additional comments (3)
ghost/core/core/server/services/Users.js (1)
10-10: Correct import path for post events.
The import ofPostsBulkAddTagsEventhas been updated to use the local shared events module (../../shared/events) instead of the external@tryghost/post-eventspackage. The relative path is correct given the file’s location (server/services), and it aligns with changes in other service files.ghost/core/core/server/services/posts/PostsService.js (1)
15-15: Align event imports to local shared module.
Redirecting event imports to../../../shared/eventsensures the post event classes are sourced from the consolidated core codebase. The relative path is accurate for thepostssubdirectory and matches the structure used inUsers.js.ghost/core/test/unit/shared/events/post-events.test.ts (1)
3-9: Update test imports to local event files.
The test now imports each post event class directly from its specific file undercore/shared/events, replacing grouped imports from the removed package. The relative paths (e.g.,../../../../core/shared/events/PostsBulkAddTagsEvent) correctly resolve from the test directory. This maintains test coverage without altering test logic.
fix https://linear.app/ghost/issue/ENG-2382/member-attribution - this commit moves the lib code and tests to the core folder so we can colocate code in one place rather than splitting it out across packages, which increases the cognitive load and overhead
daniellockyer
force-pushed
the
move-packages
branch
from
052422b to
733891e
Compare
daniellockyer
changed the title
fix https://linear.app/ghost/issue/ENG-2383/tiers - this commit moves the lib code and tests to the core folder so we can colocate code in one place rather than splitting it out across packages, which increases the cognitive load and overhead
daniellockyer
force-pushed
the
move-packages
branch
from
0ea8f65 to
257eca9
Compare
fix https://linear.app/ghost/issue/ENG-2384/link-replacer - this commit moves the lib code and tests to the core folder so we can colocate code in one place rather than splitting it out across packages, which increases the cognitive load and overhead
daniellockyer
force-pushed
the
move-packages
branch
from
60567a5 to
8208fb8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23135 +/- ##
==========================================
- Coverage 71.84% 71.83% -0.01%
==========================================
Files 1435 1435
Lines 99367 99333 -34
Branches 12201 12199 -2
==========================================
- Hits 71388 71354 -34
Misses 26989 26989
Partials 990 990
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fix https://linear.app/ghost/issue/ENG-2385/offers - this commit moves the lib code and tests to the core folder so we can colocate code in one place rather than splitting it out across packages, which increases the cognitive load and overhead
daniellockyer
force-pushed
the
move-packages
branch
from
6d5f035 to
04a298e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix https://linear.app/ghost/issue/ENG-2381/post-events