Added transtation into Russian for new lines. #23144
Conversation
|
""" WalkthroughThis pull request updates the Russian localization files for several user-facing components: comments, core platform, newsletter, and portal. The changes consist of filling in previously empty translation strings with appropriate Russian text, refining existing translations for clarity and consistency, and shortening certain time-related phrases by using abbreviations (e.g., "ч." for hours and "мин." for minutes). Adjustments also include minor wording changes, such as refining prepositions and possessive pronouns, and updating terminology (e.g., "Членство" to "Подписки" in the portal). No changes were made to any control flow, logic, or exported/public code entities; all modifications are limited to the content of JSON localization files. Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (5)
ghost/i18n/locales/ru/newsletter.json (1)
19-19: Inconsistent translation of “Upgrade”
To maintain consistency across locale files, consider using “Обновить подписку” or simply “Обновить” instead of “Улучшить подписку.”ghost/i18n/locales/ru/comments.json (2)
16-16: Consider plural form for “Best”
Suggest using “Лучшие” instead of “Лучший” to match the plural context of sorting.
70-70: Inconsistent translation of “Upgrade now”
Align this with other “Upgrade” translations (e.g., “Обновить подписку сейчас” or “Обновить”).ghost/i18n/locales/ru/ghost.json (1)
18-18: Sentence clarity could be improved
The phrase “чтобы отказать в доступе” may imply refusing access; consider “чтобы никто не получил доступ” for clearer intent.ghost/i18n/locales/ru/portal.json (1)
107-107: Consider refining the wording
The translation mentions a limit on the number of subscribers; to reflect restriction of memberships, consider “В настоящее время подписка с этого домена электронной почты ограничена.”
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
ghost/i18n/locales/ru/comments.json(4 hunks)ghost/i18n/locales/ru/ghost.json(2 hunks)ghost/i18n/locales/ru/newsletter.json(2 hunks)ghost/i18n/locales/ru/portal.json(3 hunks)
🔇 Additional comments (21)
ghost/i18n/locales/ru/newsletter.json (2)
3-3: Translation looks accurate and contextually appropriate.
20-20: Translation of full sentence is well-formed and clear.ghost/i18n/locales/ru/comments.json (4)
4-4: Clear and consistent abbreviation for hours.
5-5: Clear and consistent abbreviation for minutes.
44-44: Translation for “Newest” is concise and consistent.
45-45: Translation for “Oldest” is concise and consistent.ghost/i18n/locales/ru/ghost.json (7)
8-8: Translation correctly fills the previously missing key.
11-11: Translation is accurate and preserves placeholders.
13-13: Translation is correct and natural.
20-20: Translation accurately reflects the source.
25-25: Translation is clear and idiomatic.
37-37: Translation is clear and contextually appropriate.
42-42: Translation preserves meaning and placeholders correctly.ghost/i18n/locales/ru/portal.json (8)
18-18: Translation correctly covers the new key.
108-108: Translation accurately reflects the source.
176-176: Translation for retry message (days) is clear and consistent.
177-177: Translation for retry message (hours) is clear and consistent.
178-178: Translation for retry message (minutes) is clear and consistent.
179-179: Translation for sign-in retry (days) is clear and consistent.
180-180: Translation for sign-in retry (hours) is clear and consistent.
181-181: Translation for sign-in retry (minutes) is clear and consistent.
|
Hey @hide-me ! Thanks for the contribution. Could you please have a quick look at the issues identified by coderabbitai above? |
Added colons according to the recommendations
|
@cathysarisky sure! Fixed by adding colons according to coderabbitai recommendations |
|
@cathysarisky thank you for detailed review! I hope for now users will have 100% complete and consistent translation. If you have any other questions fell free to ask! Have a nice day 🤍 |
|
And away we go! Thanks for the contribution! I've merged it, so it should appear in the next release! (5.119.2 or 5.120) |
Because I'm russian translator for Ghost. Previous translation also made by me.
Added transtation into Russian for new lines in lang files.
It's awesome when users have completely translated UI, right?
Please check your PR against these items:
We appreciate your contribution! 🙏 --Thanks