🌐 Added missing i18n for expertise link in comments #23159
Conversation
WalkthroughThis change updates the comments UI form to internationalize the placeholder text for the expertise button. The previously hardcoded English string "Add your expertise" is replaced with a localized version using the translation function. Correspondingly, the translation key "Add your expertise" has been added to the comments localization JSON files across many supported languages. Most locale files contain the new key with an empty string value, indicating untranslated entries, while the German locale includes a translated string. Additionally, a descriptive key for this phrase was added to the context localization file. No modifications were made to application logic, control flow, error handling, or exported/public code entities. Suggested labels
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
apps/comments-ui/src/components/content/forms/Form.tsxOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-i18next". (The package "eslint-plugin-i18next" was not found when loaded as a Node module from the directory "/apps/comments-ui".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-i18next" was referenced from the config file in "apps/comments-ui/.eslintrc.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (62)
✅ Files skipped from review due to trivial changes (7)
🚧 Files skipped from review as they are similar to previous changes (55)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (5)
ghost/i18n/locales/eo/comments.json (1)
11-11: Missing Esperanto translation for "Add your expertise"
The new key"Add your expertise"has an empty value. Please provide a proper Esperanto translation (e.g.,"Aldonu vian kompetentecon") to complete the localization.ghost/i18n/locales/nn/comments.json (1)
11-11: Missing Nynorsk translation for "Add your expertise"
This new key is blank—please fill in the correct Norwegian Nynorsk translation (e.g.,"Legg til di ekspertise").ghost/i18n/locales/ca/comments.json (1)
11-11: Missing Catalan translation for "Add your expertise"
The added key is currently empty. Please add the appropriate Catalan translation (e.g.,"Afegeix la teva experiència").ghost/i18n/locales/he/comments.json (1)
11-11: Missing Hebrew translation for "Add your expertise"
The new key has no translated value. Please fill in the Hebrew translation (e.g.,"הוסף את ההתמחות שלך").ghost/i18n/locales/fi/comments.json (1)
11-11: Missing Finnish translation for "Add your expertise"
The key was added but left blank—please provide the Finnish translation (e.g.,"Lisää asiantuntemuksesi").
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (62)
apps/comments-ui/src/components/content/forms/Form.tsx(1 hunks)ghost/i18n/locales/af/comments.json(1 hunks)ghost/i18n/locales/ar/comments.json(1 hunks)ghost/i18n/locales/bg/comments.json(1 hunks)ghost/i18n/locales/bn/comments.json(1 hunks)ghost/i18n/locales/bs/comments.json(1 hunks)ghost/i18n/locales/ca/comments.json(1 hunks)ghost/i18n/locales/context.json(1 hunks)ghost/i18n/locales/cs/comments.json(1 hunks)ghost/i18n/locales/da/comments.json(1 hunks)ghost/i18n/locales/de-CH/comments.json(1 hunks)ghost/i18n/locales/de/comments.json(1 hunks)ghost/i18n/locales/el/comments.json(1 hunks)ghost/i18n/locales/en/comments.json(1 hunks)ghost/i18n/locales/eo/comments.json(1 hunks)ghost/i18n/locales/es/comments.json(1 hunks)ghost/i18n/locales/et/comments.json(1 hunks)ghost/i18n/locales/fa/comments.json(1 hunks)ghost/i18n/locales/fi/comments.json(1 hunks)ghost/i18n/locales/fr/comments.json(1 hunks)ghost/i18n/locales/gd/comments.json(1 hunks)ghost/i18n/locales/he/comments.json(1 hunks)ghost/i18n/locales/hi/comments.json(1 hunks)ghost/i18n/locales/hr/comments.json(1 hunks)ghost/i18n/locales/hu/comments.json(1 hunks)ghost/i18n/locales/id/comments.json(1 hunks)ghost/i18n/locales/is/comments.json(1 hunks)ghost/i18n/locales/it/comments.json(1 hunks)ghost/i18n/locales/ja/comments.json(1 hunks)ghost/i18n/locales/ko/comments.json(1 hunks)ghost/i18n/locales/kz/comments.json(1 hunks)ghost/i18n/locales/lt/comments.json(1 hunks)ghost/i18n/locales/lv/comments.json(1 hunks)ghost/i18n/locales/mk/comments.json(1 hunks)ghost/i18n/locales/mn/comments.json(1 hunks)ghost/i18n/locales/ms/comments.json(1 hunks)ghost/i18n/locales/nb/comments.json(1 hunks)ghost/i18n/locales/ne/comments.json(1 hunks)ghost/i18n/locales/nl/comments.json(1 hunks)ghost/i18n/locales/nn/comments.json(1 hunks)ghost/i18n/locales/pl/comments.json(1 hunks)ghost/i18n/locales/pt-BR/comments.json(1 hunks)ghost/i18n/locales/pt/comments.json(1 hunks)ghost/i18n/locales/ro/comments.json(1 hunks)ghost/i18n/locales/ru/comments.json(1 hunks)ghost/i18n/locales/si/comments.json(1 hunks)ghost/i18n/locales/sk/comments.json(1 hunks)ghost/i18n/locales/sl/comments.json(1 hunks)ghost/i18n/locales/sq/comments.json(1 hunks)ghost/i18n/locales/sr-Cyrl/comments.json(1 hunks)ghost/i18n/locales/sr/comments.json(1 hunks)ghost/i18n/locales/sv/comments.json(1 hunks)ghost/i18n/locales/sw/comments.json(1 hunks)ghost/i18n/locales/ta/comments.json(1 hunks)ghost/i18n/locales/th/comments.json(1 hunks)ghost/i18n/locales/tr/comments.json(1 hunks)ghost/i18n/locales/uk/comments.json(1 hunks)ghost/i18n/locales/ur/comments.json(1 hunks)ghost/i18n/locales/uz/comments.json(1 hunks)ghost/i18n/locales/vi/comments.json(1 hunks)ghost/i18n/locales/zh-Hant/comments.json(1 hunks)ghost/i18n/locales/zh/comments.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: Regression tests (Node 20.11.1, sqlite3)
- GitHub Check: Regression tests (Node 20.11.1, mysql8)
- GitHub Check: Ghost-CLI tests
- GitHub Check: Unit tests (Node 22.13.1)
- GitHub Check: Comments-UI tests
- GitHub Check: Unit tests (Node 20.11.1)
- GitHub Check: Database tests (Node 20.11.1, sqlite3)
- GitHub Check: Database tests (Node 22.13.1, mysql8)
- GitHub Check: Database tests (Node 20.11.1, mysql8)
🔇 Additional comments (58)
ghost/i18n/locales/tr/comments.json (1)
11-11: Correct insertion of new translation key.
The"Add your expertise"key is added in the proper alphabetical position. Please fill in the Turkish translation value.ghost/i18n/locales/uz/comments.json (1)
11-11: Correct insertion of new translation key.
The"Add your expertise"key is added in the proper alphabetical position. Please fill in the Uzbek translation value.ghost/i18n/locales/is/comments.json (1)
11-11: Correct insertion of new translation key.
The"Add your expertise"key is added in the proper alphabetical position. Please fill in the Icelandic translation value.ghost/i18n/locales/en/comments.json (1)
11-11: Correct insertion of new translation key.
The"Add your expertise"key is added in the proper alphabetical position. Ensure the English locale handles empty values by falling back to the key text.ghost/i18n/locales/ms/comments.json (1)
11-11: Correct insertion of new translation key.
The"Add your expertise"key is added in the proper alphabetical position. Please fill in the Malaysian translation value.ghost/i18n/locales/zh/comments.json (1)
11-11: New translation key added correctly
The key"Add your expertise"has been inserted with an empty placeholder, which is the expected convention for newly introduced untranslated strings.ghost/i18n/locales/sl/comments.json (1)
11-11: New translation key added correctly
The key"Add your expertise"has been added with an empty string placeholder, matching the pattern for pending translations.ghost/i18n/locales/ne/comments.json (1)
11-11: New translation key added correctly
The key"Add your expertise"is present with an empty translation placeholder, consistent with the pattern for new keys awaiting localization.ghost/i18n/locales/sr/comments.json (1)
11-11: New translation key added correctly
The key"Add your expertise"has been introduced with an empty placeholder, which aligns with other locale files pending translation.ghost/i18n/locales/ru/comments.json (1)
11-11: New i18n key introduced for expertise link
The"Add your expertise"key has been added in the correct alphabetical position. The empty string value is an intentional placeholder for translators to fill in.ghost/i18n/locales/et/comments.json (1)
11-11: New i18n key introduced for expertise link
The"Add your expertise"key has been added in the correct alphabetical position. The empty string value is an intentional placeholder for translators to fill in.ghost/i18n/locales/nb/comments.json (1)
11-11: New i18n key introduced for expertise link
The"Add your expertise"key has been added in the correct alphabetical position. The empty string value is an intentional placeholder for translators to fill in.ghost/i18n/locales/vi/comments.json (1)
11-11: New i18n key introduced for expertise link
The"Add your expertise"key has been added in the correct alphabetical position. The empty string value is an intentional placeholder for translators to fill in.ghost/i18n/locales/ja/comments.json (1)
11-11: New i18n key introduced for expertise link
The"Add your expertise"key has been added in the correct alphabetical position. The empty string value is an intentional placeholder for translators to fill in.ghost/i18n/locales/nl/comments.json (1)
11-11: Addition of new translation key
The"Add your expertise"entry has been correctly introduced with an empty placeholder value. This aligns with other locale updates and is ready for the Dutch translation.ghost/i18n/locales/bs/comments.json (1)
11-11: Addition of new translation key
The"Add your expertise"entry has been properly added with an empty placeholder. It matches the pattern used across other locale files and is ready for Bosnian translation.ghost/i18n/locales/lt/comments.json (2)
11-11: Addition of new translation key: “Add your expertise”
The new key is correctly added with an empty string placeholder, awaiting the Lithuanian translation.
14-14: Addition of new translation key: “Are you sure?”
The"Are you sure?"key has been introduced with an empty placeholder. Ensure the translation is provided to avoid fallback to the source text.ghost/i18n/locales/ko/comments.json (2)
11-11: Addition of new translation key: “Add your expertise”
The"Add your expertise"key is properly added with an empty value, ready for Korean localization.
14-14: Addition of new translation key: “Are you sure?”
The"Are you sure?"key has been added with an empty placeholder. Please supply the Korean translation to cover this prompt in the UI.ghost/i18n/locales/el/comments.json (2)
11-11: Addition of new translation key: “Add your expertise”
The"Add your expertise"key has been correctly added with an empty placeholder, matching the i18n convention across locales.
14-14: Addition of new translation key: “Are you sure?”
The"Are you sure?"entry is newly introduced with an empty value. Please ensure the Greek translation is added before release.ghost/i18n/locales/fr/comments.json (1)
11-11: i18n key added with placeholder
The new key"Add your expertise"is correctly inserted with an empty string, marking it for a future French translation. JSON syntax (commas, quoting) is valid.ghost/i18n/locales/th/comments.json (1)
11-11: i18n key added with placeholder
The new key"Add your expertise"is correctly inserted with an empty string, marking it for translation into Thai. JSON formatting remains valid.ghost/i18n/locales/bg/comments.json (1)
11-11: i18n key added with placeholder
The new key"Add your expertise"is in place with an empty value, indicating it’s pending Bulgarian translation. File structure and syntax are correct.ghost/i18n/locales/de-CH/comments.json (1)
11-11: i18n key added with placeholder
The new key"Add your expertise"has been added with an empty string for Swiss German. Ensure a proper localized string is provided before shipping.ghost/i18n/locales/gd/comments.json (1)
11-11: i18n key added with placeholder
The key"Add your expertise"is correctly added with an empty value to signal pending Gaelic translation. JSON remains well-formed.ghost/i18n/locales/bn/comments.json (1)
11-11: New i18n key added for expertise button
The translation key"Add your expertise"has been correctly inserted with an empty placeholder for Bengali. JSON syntax and key ordering remain valid.ghost/i18n/locales/cs/comments.json (1)
11-11: New i18n key added for expertise button
The translation key"Add your expertise"has been correctly inserted with an empty placeholder for Czech. JSON syntax and key ordering remain valid.ghost/i18n/locales/hi/comments.json (1)
11-11: New i18n key added for expertise button
The translation key"Add your expertise"has been correctly inserted with an empty placeholder for Hindi. JSON syntax and key ordering remain valid.ghost/i18n/locales/hr/comments.json (1)
11-11: New i18n key added for expertise button
The translation key"Add your expertise"has been correctly inserted with an empty placeholder for Croatian. JSON syntax and key ordering remain valid.ghost/i18n/locales/si/comments.json (1)
11-11: New i18n key added for expertise button
The translation key"Add your expertise"has been correctly inserted with an empty placeholder for Sinhala. JSON syntax and key ordering remain valid.ghost/i18n/locales/ta/comments.json (1)
11-11: Add missing i18n key placeholder
The new key"Add your expertise"has been correctly introduced with an empty value to serve as a placeholder for the Tamil translation.ghost/i18n/locales/sw/comments.json (1)
11-11: Add missing i18n key placeholder
The new key"Add your expertise"has been correctly introduced with an empty value to serve as a placeholder for the Swahili translation.ghost/i18n/locales/ur/comments.json (1)
11-11: Add missing i18n key placeholder
The new key"Add your expertise"has been correctly introduced with an empty value to serve as a placeholder for the Urdu translation.ghost/i18n/locales/zh-Hant/comments.json (1)
11-11: Add missing i18n key placeholder
The new key"Add your expertise"has been correctly introduced with an empty value to serve as a placeholder for the Traditional Chinese translation.ghost/i18n/locales/lv/comments.json (1)
11-11: Add missing i18n key placeholder
The new key"Add your expertise"has been correctly introduced with an empty value to serve as a placeholder for the Latvian translation.ghost/i18n/locales/es/comments.json (1)
11-11: Add i18n placeholder for "Add your expertise"
The Spanish locale now includes the new translation key with an empty string. Translation can be filled in once available.ghost/i18n/locales/af/comments.json (1)
11-11: Add i18n placeholder for "Add your expertise"
The Afrikaans locale has the new key added. Please coordinate with translators to supply the proper value.ghost/i18n/locales/sq/comments.json (1)
11-11: Add i18n placeholder for "Add your expertise"
The Albanian locale entry is in place; it currently awaits translation.ghost/i18n/locales/da/comments.json (1)
11-11: Add i18n placeholder for "Add your expertise"
The Danish locale includes the new key. Remember to populate it with the correct Danish translation.ghost/i18n/locales/sk/comments.json (1)
11-11: Added new translation key – ensure translation is provided
The"Add your expertise"key was introduced with an empty value as a placeholder. This aligns with existing untranslated entries, but please work with the localization team to supply the Slovak translation to avoid blank UI text.ghost/i18n/locales/sv/comments.json (1)
11-11: Added new translation key – ensure translation is provided
The"Add your expertise"key was introduced with an empty value as a placeholder. This follows the pattern for pending translations; please coordinate with translators to supply the Swedish translation and prevent empty UI labels.ghost/i18n/locales/pl/comments.json (1)
11-11: Added new translation key – ensure translation is provided
The"Add your expertise"key was added with an empty string placeholder. To avoid blank text in the UI, please have the Polish translation filled in by the localization team.ghost/i18n/locales/mn/comments.json (1)
11-11: Added new translation key – ensure translation is provided
You’ve added the"Add your expertise"key with an empty placeholder. Make sure the Mongolian translation is provided so this text appears correctly in the UI.ghost/i18n/locales/hu/comments.json (1)
11-11: Added new translation key – ensure translation is provided
The"Add your expertise"key shows up with an empty value as a placeholder. Please engage translators to supply the Hungarian translation to avoid an empty label in the comments form.ghost/i18n/locales/pt-BR/comments.json (1)
11-11: Add new i18n placeholder for expertise
The key"Add your expertise"has been correctly introduced with an empty value as a placeholder for Brazilian Portuguese. This aligns with the PR’s goal to internationalize the expertise link.ghost/i18n/locales/kz/comments.json (1)
11-11: Add new i18n placeholder for expertise
The key"Add your expertise"is now present as an empty placeholder in the Kazakh locale, matching the change in other languages.ghost/i18n/locales/ar/comments.json (1)
11-11: Add new i18n placeholder for expertise
The Arabic locale now includes"Add your expertise"with an empty translation, consistent with the PR’s internationalization effort.ghost/i18n/locales/de/comments.json (1)
11-11: German translation for expertise
The key"Add your expertise"has been added with the German translation"Ergänze deine Expertise". This correctly localizes the expertise link for German-speaking users.ghost/i18n/locales/id/comments.json (1)
11-11: Add new i18n placeholder for expertise
The Indonesian locale now contains"Add your expertise"as an empty placeholder. This ensures the expertise link is ready for proper localization.ghost/i18n/locales/it/comments.json (1)
11-11: Add new translation key for expertise prompt
The key"Add your expertise"has been introduced with an empty value, aligning with the other locales and ready for Italian localization when translations are available.ghost/i18n/locales/ro/comments.json (1)
11-11: Introduce expertise prompt key for Romanian locale
The"Add your expertise"key is correctly added with an empty string placeholder, matching the PR’s i18n updates. Ready for translation.ghost/i18n/locales/uk/comments.json (1)
11-11: Add Ukrainian translation key for expertise input
The new"Add your expertise"entry appears with an empty value. This matches the pattern across locales and awaits Ukrainian translation.ghost/i18n/locales/fa/comments.json (1)
11-11: Add Persian localization key for expertise prompt
The"Add your expertise"key is correctly inserted with an empty string, consistent with other locales. Please provide the Persian translation when ready.ghost/i18n/locales/pt/comments.json (1)
11-11: Introduce Portuguese key for expertise prompt
The new"Add your expertise"key is included with an empty placeholder. It aligns with the PR’s changes and is ready for Portuguese translation.apps/comments-ui/src/components/content/forms/Form.tsx (1)
202-202: Localize expertise button text
Replacing the hardcoded “Add your expertise” fallback witht('Add your expertise')correctly pulls in the translation for the current locale. This aligns with the i18n changes and maintains consistency with other buttons.ghost/i18n/locales/sr-Cyrl/comments.json (1)
11-11: Translation key added correctly
The"Add your expertise"key has been introduced. Keeping the value empty indicates that the Serbian Cyrillic translation is pending, which is the standard approach until a localized string is available.
Adds missing i18n for the expertise link in the comments-ui app including German locale.
SebastianSchroeder
force-pushed
the
add_missing_comments_i18n
branch
from
dc5c3e5 to
ac7b221
Compare
Adds missing i18n for the expertise link in the comments-ui app. I also included the German locale.