-
Notifications
You must be signed in to change notification settings - Fork 30
Add low bound to the sum of flows for transport flows #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1172 +/- ##
==========================================
- Coverage 97.78% 97.66% -0.13%
==========================================
Files 30 30
Lines 1131 1158 +27
==========================================
+ Hits 1106 1131 +25
- Misses 25 27 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b0d6fdb
to
fa3ad37
Compare
For some reason, codecov complains. However, when I run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gnawin Thanks for the changes, they look good. Minor comments on the text and two main comments:
- One for now: I see that you are not testing the new constraints, aren't you? I mean, you don't change any data in the case studies that are actually generating these constraints. I am saying this because I was expecting changes in the MPS files of one of the case studies (Norse, perhaps?). Any particular reason that I might be missing? otherwise I would suggest testing the new constraints by modifying the Norse.
- long-term, so not in this PR (for future record): some constraints might be just bounds, if the asset only has one input or output. So, if we identify those cases beforehand, we can avoid creating constraints that are actually bounds. As I said, for the future 😃
Closed in favor of #1178 |
Model
min_output_flow_with_unit_commitment
.Documentation
Related issues
Closes #1159, #1168
Checklist
I am following the contributing guidelines
Tests are passing
Lint workflow is passing
Docs were updated and workflow is passing