-
Notifications
You must be signed in to change notification settings - Fork 31
Add low bound to the sum of flows for transport flows #1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ MPS files match🤖 This was CompareMPS, we hope you have enjoyed this program. |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (83.33%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1178 +/- ##
==========================================
+ Coverage 97.62% 97.63% +0.01%
==========================================
Files 31 31
Lines 1135 1140 +5
==========================================
+ Hits 1108 1113 +5
Misses 27 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@datejada The MPS file has changed, but somehow the change was not detected. I'll update the MPS file once you have a look at the Github actions. Thanks. |
6bb1d9a
to
74d2804
Compare
74d2804
to
dcd1ad8
Compare
🤖 CompareMPS report✅ MPS files match |
🤖 CompareMPS report
|
dcd1ad8
to
af0c8c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gnawin Thanks for the PR, one last thing, I think we commented on it before but I forgot the reason. Can we make the codecov pass? or there is something why we are not testing those cases anymore.
@datejada the Github code coverage give the same results in the original PR (#1172 (comment)), while locally it was okay. I have only changed the documentation afterwards. Now when I open code coverage, it shows one line is missing for I also ran local code coverage, here are the results: So nothing is changing in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the explanation of the codecov. No more comments from y side 😃
Model
min_output_flow_with_unit_commitment
.Documentation
Testing
In this case, we want to test multiple outgoing flows from$Flow1 + Flow2 \ge 0$ , which has been checked by looking at the lp file.
CCGT
:An integration test has been added, but most probably it will be updated after DC-OPF.
Related issues
Closes #1159, #1168
Checklist
I am following the contributing guidelines
Tests are passing
Lint workflow is passing
Docs were updated and workflow is passing