-
Notifications
You must be signed in to change notification settings - Fork 36
JET + Mooncake fixes for 1.12 #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
penelopeysm
wants to merge
5
commits into
main
Choose a base branch
from
py/no-mooncake-pre
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+61
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Report for Commit d6e9c83Computer Information
Benchmark Results
|
DynamicPPL.jl documentation for PR #921 is available at: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #921 +/- ##
===========================================
- Coverage 85.01% 11.05% -73.97%
===========================================
Files 35 35
Lines 3924 3891 -33
===========================================
- Hits 3336 430 -2906
- Misses 588 3461 +2873 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 15077915515Details
💛 - Coveralls |
178599a
to
485d372
Compare
485d372
to
64daf52
Compare
c25fd4c
to
d6e9c83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
julia-version = pre
. This removes it from the test suite if the Julia version is 1.12.Previously, we knew that CI was failing on 1.12 because of Mooncake. However, removing Mooncake also flagged up a couple more errors that I had to resolve to get CI to pass:
JET.jl has a new version, v0.10, that is intended for Julia 1.12. This PR also includes v0.10 in the allowed compat ranges for JET.jl so that the tests can run on
pre
. Previously, the JET tests onpre
would fail as CI would attempt to install an older version of JET that wasn't forward-compatible. Thankfully, this doesn't require runtime checks because Pkg will automatically figure out the appropriate version of JET to install.Finally, this PR disables doctests on 1.12, because error messages vary from version to version and it can be very flaky to test correctly for them.
There is still one remaining test failure on 1.12, which is related to the use of
Threads.threadid()
inThreadSafeVarInfo
. I wrote up more about this problem in #924.Supersedes: #872 #873 #875