Skip to content

[TT-4023] Track 404 logs not showing in listening port when changing control api port #7976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaciekMis wants to merge 5 commits into
base: master
Choose a base branch
from
+7 −4

Merge branch 'master' into TT-4023-track-404-logs-not-showing-in-list…

300e2d6
Select commit
Loading
Failed to load commit list.
Open

[TT-4023] Track 404 logs not showing in listening port when changing control api port #7976

Merge branch 'master' into TT-4023-track-404-logs-not-showing-in-list…
300e2d6
Select commit
Loading
Failed to load commit list.
probelabs / Visor: architecture failed Apr 9, 2026 in 1m 8s

🚨 Check Failed

architecture check failed because fail_if condition was met.

Details

📊 Summary

  • Total Issues: 2
  • Error Issues: 2

🔍 Failure Condition Results

Failed Conditions

  • global_fail_if: output.issues && output.issues.some(i => i.severity === 'critical' || i.severity === 'error')
    • Severity: ❌ error

Issues by Category

Architecture (1)

  • ❌ gateway/server.go:2293 - A new local proxyMux instance is created here. This is architecturally inconsistent as the Gateway has a main instance (gw.proxyMux) that should be used. This local instance is not fully initialized (e.g., the again field is missing compared to the instance in NewGateway) and any state set on it (like the proxies map populated by setRouter) is discarded when the function exits. Adding the track404Logs configuration here fixes the immediate bug but reinforces this flawed pattern of using temporary, partially-configured service objects.

Logic (1)

  • ❌ system:0 - Global failure condition met: output.issues && output.issues.some(i => i.severity === 'critical' || i.severity === 'error')

Powered by Visor from Probelabs

💡 TIP: You can chat with Visor using /visor ask <your question>

Annotations

Check failure on line 2295 in gateway/server.go

See this annotation in the file changed.

@probelabs probelabs / Visor: architecture

architecture Issue 

A new local `proxyMux` instance is created here. This is architecturally inconsistent as the `Gateway` has a main instance (`gw.proxyMux`) that should be used. This local instance is not fully initialized (e.g., the `again` field is missing compared to the instance in `NewGateway`) and any state set on it (like the `proxies` map populated by `setRouter`) is discarded when the function exits. Adding the `track404Logs` configuration here fixes the immediate bug but reinforces this flawed pattern of using temporary, partially-configured service objects.
Raw output 
Refactor this function to use the gateway's shared `proxyMux` instance (`gw.proxyMux`) instead of creating a new local one. This would eliminate the need for the change in this function, as `gw.proxyMux` is already correctly configured in `NewGateway` by this pull request.
View more details on probelabs