Skip to content

[TT-4023] Track 404 logs not showing in listening port when changing control api port #7976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaciekMis wants to merge 5 commits into
base: master
Choose a base branch
from
+7 −4

Merge branch 'master' into TT-4023-track-404-logs-not-showing-in-list…

300e2d6
Select commit
Loading
Failed to load commit list.
Open

[TT-4023] Track 404 logs not showing in listening port when changing control api port #7976

Merge branch 'master' into TT-4023-track-404-logs-not-showing-in-list…
300e2d6
Select commit
Loading
Failed to load commit list.
probelabs / Visor: quality failed Apr 9, 2026 in 1m 13s

🚨 Check Failed

quality check failed because fail_if condition was met.

Details

📊 Summary

  • Total Issues: 3
  • Error Issues: 2
  • Warning Issues: 1

🔍 Failure Condition Results

Failed Conditions

  • global_fail_if: output.issues && output.issues.some(i => i.severity === 'critical' || i.severity === 'error')
    • Severity: ❌ error

Issues by Category

Logic (2)

  • ❌ gateway/server.go:2291 - The proxyMux instance created in startServer is not fully initialized. The again field is not set, which will likely cause a nil pointer dereference and a panic when ListenAndServe is called, as it internally calls m.again.Do(...). This field is correctly initialized for DefaultProxyMux in NewGateway but is missing here.
  • ❌ system:0 - Global failure condition met: output.issues && output.issues.some(i => i.severity === 'critical' || i.severity === 'error')

Architecture (1)

  • ⚠️ gateway/proxy_muxer.go:190 - The change centralizes the 404 handling logic, but no automated tests are added to verify this behavior. Without tests, it's difficult to ensure the fix is correct for all configurations (e.g., shared vs. separate control port) and to prevent future regressions.

Powered by Visor from Probelabs

💡 TIP: You can chat with Visor using /visor ask <your question>

Annotations

Check failure on line 2293 in gateway/server.go

See this annotation in the file changed.

@probelabs probelabs / Visor: quality

logic Issue 

The `proxyMux` instance created in `startServer` is not fully initialized. The `again` field is not set, which will likely cause a nil pointer dereference and a panic when `ListenAndServe` is called, as it internally calls `m.again.Do(...)`. This field is correctly initialized for `DefaultProxyMux` in `NewGateway` but is missing here.
Raw output 
The `again` field should be initialized. To prevent such inconsistencies and reduce code duplication, consider creating a constructor function (e.g., `newProxyMux`) and using it in both `NewGateway` and `startServer`.

Check warning on line 190 in gateway/proxy_muxer.go

See this annotation in the file changed.

@probelabs probelabs / Visor: quality

architecture Issue 

The change centralizes the 404 handling logic, but no automated tests are added to verify this behavior. Without tests, it's difficult to ensure the fix is correct for all configurations (e.g., shared vs. separate control port) and to prevent future regressions.
Raw output 
Add integration or unit tests to verify that 404 errors are logged correctly on all listeners according to the `track_404_logs` configuration setting.
View more details on probelabs