Skip to content

[TT-16342] fix: update OTel tracing test scenarios for Go 1.25#8042

Merged
buger merged 1 commit intorelease-5.12.1from
fix/otel-scenario-attributes-5.12.1
Apr 16, 2026
Merged

[TT-16342] fix: update OTel tracing test scenarios for Go 1.25#8042
buger merged 1 commit intorelease-5.12.1from
fix/otel-scenario-attributes-5.12.1

Conversation

@buger
Copy link
Copy Markdown
Member

@buger buger commented Apr 16, 2026

Summary

  • Update 16 OTel tracing test scenario files to use new semantic convention attribute names
  • Go 1.25 + otelhttp v0.60.0 emits new attribute names (e.g., http.response.status_code instead of http.status_code, http.request.method instead of http.method, url.full instead of http.url, server.address instead of net.peer.name, etc.)
  • Backport scenario updates from master to fix CI failures on release-5.12.1

Attribute mapping

Old (pre-Go 1.25) New (Go 1.25+)
http.status_code http.response.status_code
http.method http.request.method
http.url url.full
http.scheme url.scheme
http.wrote_bytes http.response.body.size
http.user_agent user_agent.original
net.peer.name server.address

Test plan

  • OTel tracing CI tests pass with updated scenario files
  • No regressions in other tracing-related tests

Generated with Claude Code

Go 1.25 + otelhttp v0.60.0 uses new OpenTelemetry semantic convention
attribute names (e.g., http.response.body.size instead of http.wrote_bytes,
http.response.status_code instead of http.status_code, http.request.method
instead of http.method, url.full instead of http.url, url.scheme instead of
http.scheme, user_agent.original instead of http.user_agent, server.address
instead of net.peer.name). Backport scenario updates from master.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@buger buger requested a review from a team as a code owner April 16, 2026 14:54
@probelabs
Copy link
Copy Markdown
Contributor

probelabs Bot commented Apr 16, 2026

This pull request updates 16 OpenTelemetry (OTel) tracing test scenario files to align with the new semantic convention attribute names introduced in Go 1.25 and the otelhttp library v0.60.0. The changes are a backport from the master branch to release-5.12.1 to resolve CI failures.

The modifications consist of replacing deprecated attribute keys with their new counterparts in the YAML test files (e.g., http.status_code is now http.response.status_code, http.url is url.full).

Files Changed Analysis

  • Files Modified: 16 YAML files.
  • Location: All changes are confined to the ci/tests/tracing/scenarios/ directory.
  • Nature of Changes: The changes are uniform across all files, consisting of a direct substitution of old OTel attribute names for new ones. The total additions (58) and deletions (58) are perfectly balanced, reflecting the find-and-replace nature of the update.

Architecture & Impact Assessment

  • What this PR accomplishes: It fixes the OTel integration tests by updating the test scenarios to match the new tracing attribute names emitted by the application after upgrading to Go 1.25. This ensures the CI pipeline can successfully validate the gateway's tracing output.
  • Key technical changes introduced: The PR involves updating string literals in YAML test configuration files. There are no changes to production Go code, application logic, or system architecture.
  • Affected system components: The primary impact is on the Continuous Integration (CI) test suite for OpenTelemetry tracing. It has no direct impact on the production runtime behavior of the Tyk gateway, but it reflects an underlying change in the observability data it emits.

Scope Discovery & Context Expansion

  • The scope of this PR is strictly limited to the test suite's scenario definitions. It indicates that the gateway's OTel instrumentation, which generates the traces, has been updated (likely as part of the Go 1.25 upgrade) to emit attributes compliant with the new semantic conventions.
  • While no production code is changed here, a reviewer should be aware that this is the testing counterpart to a change in the gateway's core tracing logic. The PR itself is self-contained and low-risk, as it only affects test assertions.
Metadata
  • Review Effort: 1 / 5
  • Primary Label: chore

Powered by Visor from Probelabs

Last updated: 2026-04-16T14:56:20.629Z | Triggered by: pr_opened | Commit: a7a9a3a

💡 TIP: You can chat with Visor using /visor ask <your question>

@probelabs
Copy link
Copy Markdown
Contributor

probelabs Bot commented Apr 16, 2026

✅ Security Check Passed

No security issues found – changes LGTM.

✅ Architecture Check Passed

No architecture issues found – changes LGTM.

✅ Performance Check Passed

No performance issues found – changes LGTM.


Powered by Visor from Probelabs

Last updated: 2026-04-16T14:55:50.791Z | Triggered by: pr_opened | Commit: a7a9a3a

💡 TIP: You can chat with Visor using /visor ask <your question>

@github-actions
Copy link
Copy Markdown
Contributor

API Changes

no api changes detected

@buger buger merged commit 975ddb9 into release-5.12.1 Apr 16, 2026
13 of 16 checks passed
@buger buger deleted the fix/otel-scenario-attributes-5.12.1 branch April 16, 2026 15:26
buger added a commit that referenced this pull request Apr 16, 2026
Reverts the OTel test scenario changes from PR #8042. The release-5.12.1
branch uses otelhttp v0.60.0 which defaults to OLD semantic convention
attribute names. The scenarios were incorrectly updated to expect NEW names.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
buger added a commit that referenced this pull request Apr 16, 2026
## Summary
Reverts PR #8042 which incorrectly updated OTel test scenarios to use
NEW attribute names on release-5.12.1.

release-5.12.1 uses otelhttp v0.60.0 which defaults to OLD attribute
names unless OTEL_SEMCONV_STABILITY_OPT_IN is set.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@buger buger changed the title fix: update OTel tracing test scenarios for Go 1.25 [TT-16342] fix: update OTel tracing test scenarios for Go 1.25 Apr 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Jira Linter Failed

Commit: a7a9a3a
Failed at: 2026-04-21 10:12:07 UTC

The Jira linter failed to validate your PR. Please check the error details below:

🔍 Click to view error details
failed to get Jira issue: failed to fetch Jira issue TT-16342: Issue does not exist or you do not have permission to see it.: request failed. Please analyze the request body for more details. Status code: 404

Next Steps

  • Ensure your branch name contains a valid Jira ticket ID (e.g., ABC-123)
  • Verify your PR title matches the branch's Jira ticket ID
  • Check that the Jira ticket exists and is accessible

This comment will be automatically deleted once the linter passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant