Skip to content

Conversation

@davidsklar99
Copy link
Member

Using new PostgREST api's, the strat names/concepts page now:

  • displays strat name's parent concept if applicable
  • displays concepts child strat names if applicable
  • handles display of joied list of all strat names and concepts

@davenquinn
Copy link
Member

@davidsklar99 With this PR, can you confirm that all strat names would be visible and searchable? There are strat names that don't have attached concepts and vise versa.

The "correct" way to do this would be to create a linked PR in the Macrostrat repo that contains the view definition. Then we could iterate on the right query to capture everything, and merge that before this one.

@davidsklar99
Copy link
Member Author

@davenquinn Based on the number of rows return in the original database tables vs the number of expected rows in mine, yes everything is returned correctly. Also, while scrolling through I can find strat names and concepts without linked members.

On your second point, do you mean creating a new PR where the strat names and concepts page use functions the same, just gets its data using the views instead of the api we created?

@davenquinn davenquinn merged commit 1a02793 into main Jun 9, 2025
1 check passed
@davidsklar99 davidsklar99 deleted the strat_names_test branch June 9, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants