Conversation
ellyokes253
reviewed
Jan 14, 2026
logs/heartbeat_receiver/main.log
Outdated
| 19:26:33: [INFO] [C:\Users\aclie\bootcamp_WARG_Evan_Liem\autonomy-bootcamp-2025-p2\tests\integration\test_heartbeat_receiver.py | read_queue | 79] Heartbeat status: Disconnected | ||
| 19:26:35: [INFO] [C:\Users\aclie\bootcamp_WARG_Evan_Liem\autonomy-bootcamp-2025-p2\tests\integration\test_heartbeat_receiver.py | read_queue | 79] Heartbeat status: Disconnected | ||
| 19:26:36: [INFO] [C:\Users\aclie\bootcamp_WARG_Evan_Liem\autonomy-bootcamp-2025-p2\tests\integration\test_heartbeat_receiver.py | read_queue | 79] Heartbeat status: Disconnected | ||
| 19:26:36: [INFO] [C:\Users\aclie\bootcamp_WARG_Evan_Liem\autonomy-bootcamp-2025-p2\tests\integration\test_heartbeat_receiver.py | read_queue | 79] Heartbeat status: Connected |
Contributor
There was a problem hiding this comment.
should be 4 disconnects in a row
ellyokes253
reviewed
Jan 14, 2026
| # Mock starting a worker, since cannot actually start a new process | ||
| # Create a worker controller for your worker | ||
| controller = worker_controller.WorkerController() | ||
| args = controller |
Contributor
There was a problem hiding this comment.
just put the controller in the arguements instead
ellyokes253
reviewed
Jan 14, 2026
ellyokes253
reviewed
Jan 14, 2026
bootcamp_main.py
Outdated
Comment on lines
259
to
263
| try: | ||
| command_output = command_to_main_queue.queue.get(timeout=0.2) | ||
| main_logger.info(f"Command output: {command_output}", True) | ||
| except queue.Empty: | ||
| pass |
Contributor
There was a problem hiding this comment.
this can be in the same try and except block
Contributor
|
reviewed! |
ellyokes253
reviewed
Jan 21, 2026
modules/command/command_worker.py
Outdated
Comment on lines
76
to
77
| if telemetry_data is None: | ||
| break |
Contributor
There was a problem hiding this comment.
just because there's nothing in the queue yet doesn't mean the logic should break
All review feedback addressed: - Fixed heartbeat_receiver to show 4+ disconnects (timer +3) - Added queue draining to all test stop() functions - Combined try-except blocks in bootcamp_main.py - Fixed command_worker queue handling (timeout/continue pattern, no break on None) - All integration tests passing - Code formatted with black - No linter errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests:
Logs: