feat: update schedule parsing service to retrieve classrooms#172
Draft
a23kumar wants to merge 1 commit intoUWFlow:mainfrom
Draft
feat: update schedule parsing service to retrieve classrooms#172a23kumar wants to merge 1 commit intoUWFlow:mainfrom
a23kumar wants to merge 1 commit intoUWFlow:mainfrom
Conversation
a23kumar
changed the title
|
This breaks UW API policy. UW flow has not been allowed to parse classrooms since the HH stabing (unless we make it behind afds) |
a23kumar
changed the title
a23kumar
changed the title
Author
|
This is not accessing UW's API. This is an update to the schedule parsing service. All room data is private to the user and is unique to their schedule that they have provided. I think I wrongly named this PR causing this confusion, and I have renamed it correctly. |
|
Sorry the name confused me, sorry about that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #171
This PR updates the schedule parsing service to extract and return classroom information from schedule data.
Changes
schedule.goClassroomsfield inschedule_test.goThis will allow the API to provide classroom details along with existing schedule information.