Merged
Conversation
Pull reviewers statsStats of the last 120 days for UWOrbital:
|
Yarik-Popov
requested changes
Feb 23, 2025
Contributor
Yarik-Popov
left a comment
Yarik-Popov
left a comment
There was a problem hiding this comment.
Very good. Just one thing to add. For all the classes that inherit from BaseOrbitalException, add to their doc string the info about the message attribute. Same as you did in the BaseOrbitalException. Once that is done, lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Implemented a custom list of exceptions to catch our own exceptions and handle them appropriately in specific manners depending on the type. Task: https://www.notion.so/uworbital/Create-custom-exceptions-1918a26d7677803dab4ce576a11a5ebb?pvs=4
New Changes
Created a custom list of exceptions that all inherit from a BaseOrbitalException class
Testing
N/A
Outstanding Changes
N/A