Skip to content

Refactor ARO User Endpoints#628

Merged
LegendaryAKx3 merged 4 commits intomainfrom
627-refactor-aro-user-endpoints
Nov 19, 2025
Merged

Refactor ARO User Endpoints#628
LegendaryAKx3 merged 4 commits intomainfrom
627-refactor-aro-user-endpoints

Conversation

@LegendaryAKx3
Copy link
Contributor

Purpose: Refactor ARO User endpoints

Closes #627 .
Explain the purpose of the PR here if it doesn't match the linked issue. Be sure to add a comment in the linked issue explaining the changes.
Refactor the ARO User endpoints to use the new data wrapper

New Changes

Explain new changes below in short bullet points.

  • Delete the update user endpoint
  • Refactor all user endpoints to use abstract data wrapper
  • Create get by id endpoint (with unit tests)
  • No changes were needed for the existing unit tests

Testing

Explain tests that you ran to verify code functionality.

  • [x ] I have unit-tested this PR. Otherwise, explain why it cannot be unit-tested.
  • I have tested this PR on a board if the code will run on a board (Only required for firmware developers).
  • I have tested this PR by running the ARO website (Only required if the code will impact the ARO website).
  • I have tested this PR by running the MCC website (Only required if the code will impact the MCC website).
  • [x ] I have included screenshots of the tests performed below.
image

Outstanding Changes

If there are non-critical changes (i.e. additional features) that can be made to this feature in the future, indicate them here.

@LegendaryAKx3 LegendaryAKx3 linked an issue Nov 12, 2025 that may be closed by this pull request
4 tasks
@github-actions
Copy link

Pull reviewers stats

Stats of the last 120 days for UWOrbital:

User Total reviews Time to review Total comments
Adityya-K
🥇
58
▀▀▀▀▀
1d 11h 27m
184
▀▀▀▀
camspec
🥈
29
▀▀▀
1d 12h 33m
172
▀▀▀▀
kepler452b123
🥉
14
6d 7h 42m
37
proprogrammer504
4
7d 1h 30m
▀▀
11
Yarik-Popov
2
1d 18h 55m
34
sunray4
1
12d 21m
▀▀▀
9
c4bae
1
13d 1h 35m
▀▀▀
2

⚡️ Pull request stats

Copy link
Contributor

@Syzygicality Syzygicality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just adding onto Kevin's review

Copy link
Contributor

@proprogrammer504 proprogrammer504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Syzygicality Syzygicality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@LegendaryAKx3 LegendaryAKx3 merged commit af1939f into main Nov 19, 2025
49 checks passed
@LegendaryAKx3 LegendaryAKx3 deleted the 627-refactor-aro-user-endpoints branch November 19, 2025 15:36
@github-actions github-actions bot added this to the 25F milestone Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor ARO user endpoints

3 participants