Skip to content

InsertAtLayerChange: Make the conversion to uppercase optional #20444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wawanbreton merged 3 commits into from
Jun 16, 2025
Merged

InsertAtLayerChange: Make the conversion to uppercase optional #20444

wawanbreton merged 3 commits into from
Jun 16, 2025

Conversation

@HellAholic
Copy link
Contributor

@HellAholic HellAholic commented Mar 25, 2025 •
edited
Loading

Add an option to allow users to not convert to uppercase.

  • Add the option type bool

  • Set to be enabled by default

  • Add condition to only convert if bool value is true

  • New feature (non-breaking change which adds functionality)

Solves: #20441

@HellAholic
Make the conversion to uppercase optional
c91862f 
- Add the option type bool
- Set to be enabled by default
- Add condition to only convert if bool value is true
@HellAholic HellAholic added PR: Community Contribution 👑 Community Contribution PR's PR: Post Processing ➕ Like adding beeps, more tunability or different Gcode pause at heights labels Mar 25, 2025
@HellAholic HellAholic mentioned this pull request Mar 25, 2025
Open
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

Test Results

23 607 tests  ±0   23 605 ✅ ±0   46s ⏱️ ±0s
     1 suites ±0        2 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit c91862f. ± Comparison against base commit fa1ead3.

@GregValiant
Copy link
Collaborator

GregValiant commented Mar 25, 2025

For all the myriad settings I stick into things it never occurred to me to add this. I thought about no uppercase, but Marlin doesn't read lowercase commands. The only reason I put the "upper" in there was to catch typos.
Nice fix. Simple and even I can understand it.

@jellespijker jellespijker requested a review from Copilot April 4, 2025 22:09
Copilot AI reviewed Apr 4, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

wawanbreton
wawanbreton approved these changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@wawanbreton wawanbreton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a question

@wawanbreton wawanbreton merged commit 3579d85 into main Jun 16, 2025
1 check passed
@wawanbreton wawanbreton deleted the PostProcessing_InsertAtLayerChange_update branch June 16, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@wawanbreton wawanbreton wawanbreton approved these changes

Assignees

No one assigned

Labels

PR: Community Contribution 👑 Community Contribution PR's PR: Post Processing ➕ Like adding beeps, more tunability or different Gcode pause at heights

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HellAholic @GregValiant @wawanbreton