Skip to content

InsertAtLayerChange: Make the conversion to uppercase optional #20444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wawanbreton merged 3 commits into from
Jun 16, 2025
Merged

InsertAtLayerChange: Make the conversion to uppercase optional #20444

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c91862f
Make the conversion to uppercase optional
HellAholic Mar 25, 2025
facf0b7
Merge branch 'main' into PostProcessing_InsertAtLayerChange_update
wawanbreton Jun 16, 2025
5db75ac
No need for type cast -> it returns a bool
HellAholic Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion plugins/PostProcessingPlugin/scripts/InsertAtLayerChange.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Copyright (c) 2020 Ultimaker B.V.
# Created by Wayne Porter
# Re-write in April of 2024 by GregValiant (Greg Foresi)
# Made convert inserted text to upper-case optional March 2025 by HellAholic
# Changes:
# Added an 'Enable' setting
# Added support for multi-line insertions (comma delimited)
Expand Down Expand Up @@ -82,6 +83,14 @@ def getSettingDataString(self):
"type": "str",
"default_value": "",
"enabled": "enabled"
},
"convert_to_upper":
{
"label": "Convert to upper-case",
"description": "Convert all inserted text to upper-case as some firmwares don't understand lower-case.",
"type": "bool",
"default_value": true,
"enabled": "enabled"
}
}
}"""
Expand All @@ -91,7 +100,7 @@ def execute(self, data):
if not bool(self.getSettingValueByKey("enabled")):
return data
#Initialize variables
mycode = self.getSettingValueByKey("gcode_to_add").upper()
mycode = self.getSettingValueByKey("gcode_to_add").upper() if self.getSettingValueByKey("convert_to_upper") else self.getSettingValueByKey("gcode_to_add")
start_layer = int(self.getSettingValueByKey("start_layer"))
end_layer = int(self.getSettingValueByKey("end_layer"))
when_to_insert = self.getSettingValueByKey("insert_frequency")
Expand Down
Loading