Integrate npm package publish #2184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new workflows for Conan v2 to build and publish and npm package Contribute to NP-637
4 tasks
Contributor
Test Results27 tests 27 ✅ 5s ⏱️ Results for commit 2095fcc. ♻️ This comment has been updated with latest results. |
rburema
approved these changes
Dec 10, 2024
Member
rburema
left a comment
rburema
left a comment
There was a problem hiding this comment.
lgtm, but I do have a few suggestions
casperlamboo
approved these changes
Dec 11, 2024
The npmpackage Python requirement was introduced to handle package.json configuration for Emscripten builds. This simplifies the code by delegating the package.json setup to the npmpackage module, reducing redundancy and maintaining cleaner logic. Contribute to NP-637
Added checks to validate minimum compiler versions and enforce C++20 compatibility for the package. These include GCC 12, Clang 14, Apple Clang 13, MSVC 191, and Visual Studio 17. This ensures compatibility with the required C++ features, preventing builds with unsupported compilers. Contribute to NP-637
Contribute to NP-637
Contribute to NP-637
wawanbreton
approved these changes
Dec 12, 2024
Contributor
wawanbreton
left a comment
wawanbreton
left a comment
There was a problem hiding this comment.
One remark, looks good otherwise
| settings = "os", "compiler", "build_type", "arch" | ||
| package_type = "application" | ||
| python_requires = "sentrylibrary/1.0.0@ultimaker/stable" | ||
| python_requires = "sentrylibrary/1.0.0@ultimaker/stable", "npmpackage/[>=1.0.0]@ultimaker/np_637" |
Contributor
There was a problem hiding this comment.
I guess there is no way to have this dependend on settings.os ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish a NPM package from a conan recipe.
This is based on
mainfrom the work done on #2183Renamed the
conan-package.ymlworkflow topackage.ymlsince it is now also used for NPM packagesAdded a
confto the recipe, which is used by the conan npm generator to generate apackage.json. NPM packages are created on pushes tomain,NP-*and5.10release branch and they will end up here: https://github.com/Ultimaker/CuraEngine/pkgs/npm/curaenginejsYes, the hardcoded
5.10hurts.Yes, the replacement of the
+to-in the version of thepackage.jsonhurts, but NPM kept "sanitizing" the build-meta data away and the version needs to be unique.See also:
Checklist: