Beta Version [Meta Pull Request]

[dgruss]

This pull request is not meant for merging!!

Note that this PR includes the duet highscore that adds a column to the highscore database and the nullbyte database fix that changes the database irrevocably.

Builds

• Windows ZIP: https://github.com/UltraStar-Deluxe/USDX/actions/runs/26186407870/artifacts/7120097869
• Windows Installer: https://github.com/UltraStar-Deluxe/USDX/actions/runs/26186407870/artifacts/7120095724
• Linux: https://github.com/UltraStar-Deluxe/USDX/actions/runs/26186407870/artifacts/7120085813
• macOS (Arm): https://github.com/UltraStar-Deluxe/USDX/actions/runs/26186407870/artifacts/7120174000
• macOS (Intel): https://github.com/UltraStar-Deluxe/USDX/actions/runs/26186407870/artifacts/7120323311

I merged the PRs mainly in chronological order, which worked alright.

Instead it combines numerous open pull requests (compared to master) for beta testing purposes:

• ✅ [150 LoC] Refresh active playlists during song preview #1305
• ✅ [150 LoC] Improve editor note splitting #1299
• ✅ [2 LoC] Check pitch threshold across full buffer #1283
• ✅ [200 LoC] Add pitch diagnostics in options screen and show correct pitch in editor #1281
• ✅ [50 LoC] Fix song list mouse hitboxes and tag refresh #1273
• ✅ [30 LoC] round scores to whole numbers, but not multiples of 10 #1268
• ✅ [40 LoC] midi volume control should be immediate and include midi emulation #1267
• ✅ [250 LoC] Refactor mouse actions in editor: fix collisions and smaller editor bugs #1266
• ✅ [550 LoC] Add more playlist control to the game #1252
• ✅ [150 LoC] Improve theme and skin inheritance handling #1249
• ✅ [50 LoC] Fix z score for mouse interaction #1245
• ✅ [100 LoC] Fix playlist selection, scrolling, and non-fixed start behavior #1241
• ✅ [? LoC] Scale up resources for higher resolution displays and add proper minification #1213
• ✅ [? LoC] Remove duplicated theme assets and fallback to base theme instead #1212
• ✅ [300 LoC] fix editor save error dialog: fix scaling, allow saving anyways, go to error, and fix interaction with Alt+V on macOS #1211
• ✅ [2000 LoC] Editor: vocals pitch preview and live score estimation #1210
• ✅ [100 LoC] show how perfect singing scores would split up to normal notes, line bonus, and golden notes in the editor #1209
• ✅ [80 LoC] allow playlist restriction for all party modes #1208
• ✅ [80 LoC] write song errors into a separate log file #1206
• ✅ [~20 LoC] Improvement: Allow Alt + Key to search for more than just the starting letter and escaping current folder #1197
• ✅ [-7k LoC] Cleanup: Remove the Jukebox feature (replaced by loop mode in Song Screen) #1195
• ✅ [~80 LoC] Bugfix: prevent Windows from making a screenshot while we make a screenshot #1194
• ✅ [~900 LoC] Cleanup/Improvement: New Loop Mode in Song Screen intended to replace the entire Jukebox mode #1193
• ✅ [~100 LoC] Bugfix/Improvement: sustain music across screens #1192
• ✅ [~40 LoC] Improvement: allow to full screen the video preview with V in the song selection #1190
• ✅ [~100 LoC] Improvement: Make more elements themeable and configurable #1189
• ✅ [~30 LoC] Improvement: check whitespace issues locally within the Makefile #1188
• ✅ [+6.5k -9.5k] Improvement: Allow arbitrary player counts: complete refactor of how player counts are handled #1186 --> equivalent to 1284,1285,1286,1287,1288,1289,1290,1291,1292,1293,1294,1295
• ✅ [~50 LoC] Bugfix: don't suggest uninstall on reinstall and don't delete avatars unless user wants it #1183
• ✅ [~70 LoC] Bugfix: don't crash if language file cannot be loaded. fallback to english, then fallback to no language rather than crash #1179
• ✅ [5 LoC] Improve picture quality #1165
• ✅ [~100 LoC] Bugfix: fix unicode path issue on windows #1151
• ✅ [~900 LoC] Bugfix/Improvement: Scaling mechanism for rendering with correct aspect ratio #1146
• ✅ [~400 LoC] Improvement: add a scorebar feature indicating what score is still possible for a player #1139
• ✅ [ ~4000 LoC] Improvement: Translate Help screens to the selected game language #1116
• ✅ [~400 LoC] Fix: broken timings of clicks and midi notes in the editor #1109
• ✅ [6 LoC] allow both ctrl + shift to change pitches while not in duet mode #1089
• ✅ [~100 LoC] handle repeat keys when shifting notes #1073
• ✅ [~100 LoC] allow setting a per player delay via the .ini file #1052
• ✅ [~200 LoC] Improve statistics detail paging and overview summaries #1010
• ✅ [~2800 LoC] Change the Highscore List from a static Top 5 to a dynamic Top N #1009
• ✅ [~100 LoC] Duet Highscore #1004

Skipped / Look unfinished / Duplicate:

• ⛔ Port to Modern OpenGL #1296
• ⛔ Add .vscode configs in .vscode-dist. #1217
• ⛔ make the note color in the editor configurable #1085
• ⛔ Key Bindings Prototype #1078
• ⛔ Webserver #1077
• ⛔ [CI] Add ARM build for Linux #995
• ⛔ [WIP] Songlist webserver #911
• ⛔ Add UWebServer which serves the list of available songs on localhost,… #852
• ⛔ on the highscores/top5 screen, only show the highest score per player #725
• ⛔ make the rendering of the oscilloscope significantly less expensive #619
• ⛔ Beat notes #591
• ⛔ Fix macOS crackling/stuttering related to SDL buffer, use Portaudio for playback instead of SDL #576
• ⛔ improve logging of portaudio + sdl audio latency #575
• ⛔ add more functions to use in Lua plugins #554
• ⛔ Start a TeX manual #503
• ⛔ Fix controller keyboard simulation #243

[barbeque-squared]

FYI, at this point the spam this "PR" is causing in other legit issues and PRs is getting annoying and out of hand. The 5 million force-pushes on things that most of the time don't need it (they don't conflict) or sometimes even after they've already been approved (why??) are annoying enough on their own, but there's a new kid on the block and it's the six billion "mentioned this pull request/issue on ..." and I request you stop causing those.

You can see the kind of spam on the Conversation tab on other issues. I don't know if it'll also trigger on just having the commits but you might want to stop doing #<number> autolinks and just use <number> title instead or something. Thanks.

[dgruss]

I'd hope that this PR gets irrelevant and closed at some point. But we're not quite there yet with more people moving to this version, the situation might be better in a few months when fewer prs are open.