Skip to content

Check pitch threshold across full buffer#1283

Merged
barbeque-squared merged 1 commit into
UltraStar-Deluxe:masterfrom
dgruss:full-buffer-pitch-threshold
May 27, 2026
Merged

Check pitch threshold across full buffer#1283
barbeque-squared merged 1 commit into
UltraStar-Deluxe:masterfrom
dgruss:full-buffer-pitch-threshold

Conversation

@dgruss
Copy link
Copy Markdown
Contributor

@dgruss dgruss commented May 10, 2026

  • Check the pitch detection volume threshold across the full analysis buffer instead of only the first 1024 samples.
  • Removes the arbitrary early-buffer limit where a valid note could be ignored if the singer was quiet only in that slice.
  • Keeps the configured threshold values and pitch detection flow otherwise unchanged.
  • Quiet singers may find that more fragments are picked up now.

@dgruss dgruss force-pushed the full-buffer-pitch-threshold branch from 2adcbf0 to 00cd4fe Compare May 12, 2026 04:57
@dgruss dgruss force-pushed the full-buffer-pitch-threshold branch from 00cd4fe to 6d85dd2 Compare May 13, 2026 17:27
@dgruss dgruss force-pushed the full-buffer-pitch-threshold branch from 6d85dd2 to 3d511a1 Compare May 13, 2026 17:47
Copy link
Copy Markdown
Member

@barbeque-squared barbeque-squared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inb4 we get a complaint "but this affects scoring!!!!"

well yeah duh. the last 1024 in the buffer are the newest samples so obviously it makes so much sense to determine if we need to try scoring at all by looking at the first 1024. perhaps with this change we won't miss the beginning of sentences anymore. score difference would be very minimal anyway.

@barbeque-squared barbeque-squared merged commit dc7dfef into UltraStar-Deluxe:master May 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants