Check pitch threshold across full buffer#1283
Merged
barbeque-squared merged 1 commit intoMay 27, 2026
Merged
Conversation
Contributor
dgruss
commented
May 10, 2026
- Check the pitch detection volume threshold across the full analysis buffer instead of only the first 1024 samples.
- Removes the arbitrary early-buffer limit where a valid note could be ignored if the singer was quiet only in that slice.
- Keeps the configured threshold values and pitch detection flow otherwise unchanged.
- Quiet singers may find that more fragments are picked up now.
2adcbf0 to
00cd4fe
Compare
00cd4fe to
6d85dd2
Compare
6d85dd2 to
3d511a1
Compare
barbeque-squared
approved these changes
May 27, 2026
Member
barbeque-squared
left a comment
There was a problem hiding this comment.
inb4 we get a complaint "but this affects scoring!!!!"
well yeah duh. the last 1024 in the buffer are the newest samples so obviously it makes so much sense to determine if we need to try scoring at all by looking at the first 1024. perhaps with this change we won't miss the beginning of sentences anymore. score difference would be very minimal anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.