Refactor Players 6/12: song duet layout on song selection screen#1289
Draft
dgruss wants to merge 6 commits into
Draft
Refactor Players 6/12: song duet layout on song selection screen#1289dgruss wants to merge 6 commits into
dgruss wants to merge 6 commits into
Conversation
dgruss
changed the title
dgruss
force-pushed
the
refactorplayers-12-06-song-duet-layout
branch
from
5646467 to
3618219
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of splitting #1186. Builds on #1288.
Files changed in this PR:
This replaces fixed duet singer label placement on the song selection screen with generated player slots. It prepares the song screen for arbitrary player counts and removes one fixed-player layout path.
Comparison for 2 players:
Comparison for 6 players:
This is already improving things for the 2-6 player numbers ;)