Refactor Players: 8/12: generic sing screen layout#1291
Draft
dgruss wants to merge 8 commits into
Draft
Conversation
dgruss
force-pushed
the
refactorplayers-12-08-sing-lane-layout
branch
from
0c19992 to
eaa7c12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of splitting #1186. Builds on #1290.
Files changed in this PR:
This starts moving the sing screen’s player lanes to the generic layout system. It prepares the live singing UI for more than the old fixed player counts.
Comparison for 2 players duet:
Comparison for 6 players duet (there are some overlaps as this uses in part old layouting and in part new layouting to keep the diff per PR smaller):
Comparison for 2 players regular:
Comparison for 6 players regular:
Note that some placements are not great yet, this is because this PR is split out from #1186 and in part uses the new layout and in part the old layout mechanism! Check out #1292 for the next step.