Refactor Players 10/12: full switch to new generic sing controller slots#1293
Draft
dgruss wants to merge 10 commits into
Draft
Refactor Players 10/12: full switch to new generic sing controller slots#1293dgruss wants to merge 10 commits into
dgruss wants to merge 10 commits into
Conversation
dgruss
changed the title
dgruss
force-pushed
the
refactorplayers-12-10-sing-view-slots
branch
from
2957093 to
9f2f3b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of splitting #1186. Builds on #1292.
Files changed in this PR:
This completes the main sing-view migration to generic player slot data. The live singing screen now follows the same placement model as the other refactored screens.
2 players duet:
6 players duet (note the 3x2 layout instead of 2x3 due to the lyrics part at the top):
2 players regular:
6 players regular (note the 2x3 layout on both sides as there is not lyrics part at the top):
The new layouting takes actual space into account and chooses whether to add a row or a column to optimize the space usage.