Change to multiplicative terminology for combining finite sequences in semigroups, monoids, and groups#1761
Draft
lowasser wants to merge 7 commits intoUniMath:masterfrom
Draft
Change to multiplicative terminology for combining finite sequences in semigroups, monoids, and groups#1761lowasser wants to merge 7 commits intoUniMath:masterfrom
lowasser wants to merge 7 commits intoUniMath:masterfrom
Conversation
lowasser
commented
Dec 23, 2025
| where | ||
|
|
||
| abstract | ||
| cons-product-fin-sequence-type-Monoid : |
Collaborator
Author
There was a problem hiding this comment.
GitHub doesn't make the difference easy to see, so I will call it out: the original versions of these functions expected you to exhibit the value at the head of the sequence and an identity proving it is the head of the sequence, but I think that should really be an ap after the invocation of this function, not combined in. The main use case that had to change is binomial-theorem-semirings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm no longer convinced the additive terminology avoids any confusion.