docs: note fillTimeBlocks (V3) is consumed by the RFQ circuit breaker - #684
Open
codyborn wants to merge 2 commits into
Open
docs: note fillTimeBlocks (V3) is consumed by the RFQ circuit breaker#684codyborn wants to merge 2 commits into
codyborn wants to merge 2 commits into
Conversation
x-parameterization-api's fade-rate cron now keys V3 fade detection off archived_orders.fillTimeBlocks (fillTimeBlocks >= 0 => filled on/after decayStartBlock => fade). Add a comment so this calculation isn't changed without considering the downstream circuit-breaker impact. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
alanhwu
self-requested a review
July 8, 2026 20:48
alanhwu
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a comment in
check-order-status/service.tsflagging that the V3fillTimeBlockscalculation is now a load-bearing input to a downstream consumer.Why
x-parameterization-api's fade-rate cron (the RFQ circuit breaker) was extended to count Dutch_V3 fades. Because V3 decays by block rather than time, it keys fade detection offarchived_orders.fillTimeBlocks, which is computed here for V3 as:So
fillTimeBlocks >= 0(filled on/afterdecayStartBlock) ⟹ the price had begun decaying ⟹ fade. This was chosen overdecayStartBlock/startBlockdirectly because that field isn't loaded into the analytics tables, whereasfillTimeBlocksis.This PR is comment-only — no behavior change. It just warns future editors that altering the V3
fillTimeBlockscomputation affects filler fade scoring in the circuit breaker.Related
fillTimeBlocksinstead of the non-existentstartBlockcolumn)🤖 Generated with Claude Code