Skip to content

docs: note fillTimeBlocks (V3) is consumed by the RFQ circuit breaker #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codyborn wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: note fillTimeBlocks (V3) is consumed by the RFQ circuit breaker #684

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ac2f3a
docs: note fillTimeBlocks for V3 is consumed by the RFQ circuit breaker
codyborn Jun 16, 2026
fca365d
Merge branch 'main' into codyborn/note-filltimeblocks-rfq-circuit-bre…
alanhwu Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/handlers/check-order-status/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,10 @@ export class CheckOrderStatusService {
case OrderType.Dutch_V2: // Approximation
fillTimeBlocks = fillBlock - timestampToBlockNumber(block, order.cosignerData.decayStartTime, chainId);
break;
case OrderType.Dutch_V3: // Exact
// Exact. NOTE: fillTimeBlocks for V3 is consumed by the RFQ circuit breaker
// in x-parameterization-api, which treats fillTimeBlocks >= 0 (filled on/after
// decayStartBlock) as a fade. Changing this calculation affects filler fade scoring.
case OrderType.Dutch_V3:
fillTimeBlocks = fillBlock - order.cosignerData.decayStartBlock;
break;
case OrderType.Priority: { // Approximation
Expand Down
Loading