-
Notifications
You must be signed in to change notification settings - Fork 279
test: add intentional syntax errors to deployment script #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Claude Code Review
Critical Issues FoundThis PR introduces compilation-breaking syntax errors:
These changes break the deployment script. The contract will not compile in its current state. 💡 Want a fresh review? Add a comment containing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📋 Review verdict: REQUEST_CHANGES
👆 The main review comment above is the source of truth for this PR review. It is automatically updated on each review cycle, so always refer to it for the most current feedback.
This formal review submission is for the verdict only. 3 inline comment(s) are attached below.
| abstract contract DeployUniversalRouter is Script { | ||
| RouterParameters internal params; | ||
| address internal unsupported; | ||
| RouterParameters internal params |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon. This will cause a compilation error.
| RouterParameters internal params | |
| RouterParameters internal params; |
| RouterParameters internal params; | ||
| address internal unsupported; | ||
| RouterParameters internal params | ||
| address internal unsupported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon. This will cause a compilation error.
| address internal unsupported | |
| address internal unsupported; |
|
|
||
| address constant UNSUPPORTED_PROTOCOL = address(0); | ||
| bytes32 constant BYTES32_ZERO = bytes32(0); | ||
| bytes32 constant BYTES32_ZEO = bytes32(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: BYTES32_ZEO should be BYTES32_ZERO. This appears to be unintentional.
✨ Claude-Generated Content
Summary
Test commit that introduces intentional syntax errors and a typo to the deployment script.
Changes
DeployUniversalRouter.s.sol(lines 13-14)BYTES32_ZEROtoBYTES32_ZEO(typo - missing 'R')Notes