Skip to content

test: add intentional syntax errors to deployment script #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marktoda wants to merge 1 commit into from
Closed

test: add intentional syntax errors to deployment script #466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions script/DeployUniversalRouter.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ import {UniversalRouter} from 'contracts/UniversalRouter.sol';
bytes32 constant SALT = bytes32(uint256(0x00000000000000000000000000000000000000005eb67581652632000a6cbedf));

abstract contract DeployUniversalRouter is Script {
RouterParameters internal params;
address internal unsupported;
RouterParameters internal params
Copy link

@github-actions github-actions bot Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon. This will cause a compilation error.

Suggested change
RouterParameters internal params
RouterParameters internal params;

address internal unsupported
Copy link

@github-actions github-actions bot Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon. This will cause a compilation error.

Suggested change
address internal unsupported
address internal unsupported;


address constant UNSUPPORTED_PROTOCOL = address(0);
bytes32 constant BYTES32_ZERO = bytes32(0);
bytes32 constant BYTES32_ZEO = bytes32(0);
Copy link

@github-actions github-actions bot Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: BYTES32_ZEO should be BYTES32_ZERO. This appears to be unintentional.


error Permit2NotDeployed();

Expand Down
Loading