chore(deps): maintain Claude Code Action workflows (cca=v1.0.185, ait=c4820d6) - #488
chore(deps): maintain Claude Code Action workflows (cca=v1.0.185, ait=c4820d6)#488wkoutre wants to merge 3 commits into
Conversation
🤖 Claude Code Review
SummaryMaintenance bump of the two Re-review status: both prior findings still unresolvedThe PR was force-updated (previous review saw 1. Pin split inside The reusable workflow now executes at 2.
Nothing references it, so reviews now run on the toolkit default prompt. Two coherent end states: delete the file, or restore the input if that repo-specific guidance was still meant to apply. Leaving it in place means a future reader will reasonably assume it's live when it isn't. Not flagged
Verdict rationaleNo bugs or security issues in the changed lines, but this is a two-line maintenance PR where both previously-raised items are still open and one is a live version-skew inconsistency. Using COMMENT rather than APPROVE so the 💡 Want a fresh review? Add a comment containing |
There was a problem hiding this comment.
📋 Review verdict: APPROVE
👆 The main review comment above is the source of truth for this PR review. It is automatically updated on each review cycle, so always refer to it for the most current feedback.
This formal review submission is for the verdict only.
|
Refreshed pin to |
Superseded by new review after PR update
There was a problem hiding this comment.
📋 Review verdict: APPROVE
👆 The main review comment above is the source of truth for this PR review. It is automatically updated on each review cycle, so always refer to it for the most current feedback.
This formal review submission is for the verdict only. 2 inline comment(s) are attached below.
| ) | ||
|
|
||
| uses: Uniswap/ai-toolkit/.github/workflows/_claude-code-review.yml@96ef665ba04221de07e94fcc3ea69fe32c7cf306 | ||
| uses: Uniswap/ai-toolkit/.github/workflows/_claude-code-review.yml@9b405c71e42d0cec4026f2c158edf99716600baa |
There was a problem hiding this comment.
The uses: pin moves to 9b405c7, but toolkit_ref just below (line 29) stays on 96ef665. That means the reusable workflow executes at the new revision while checking out toolkit assets from the old one.
That's a legitimate configuration, but since every other pin in this PR moved in lockstep it looks unintentional. If this is a full bump, update toolkit_ref too; if the older assets are needed on purpose, add a brief comment so the next maintenance pass doesn't change it blindly.
| uses: Uniswap/ai-toolkit/.github/workflows/_claude-code-review.yml@9b405c71e42d0cec4026f2c158edf99716600baa | |
| uses: Uniswap/ai-toolkit/.github/workflows/_claude-code-review.yml@9b405c71e42d0cec4026f2c158edf99716600baa | |
| with: | |
| pr_number: ${{ github.event.pull_request.number }} | |
| base_ref: ${{ github.base_ref }} | |
| force_review: false | |
| toolkit_ref: 9b405c71e42d0cec4026f2c158edf99716600baa |
There was a problem hiding this comment.
Still unresolved on the current head. The pin has since moved from 9b405c7 to c4820d6, but toolkit_ref on line 29 is still 96ef665, so the mismatch I originally flagged is unchanged:
line 24: uses: ..._claude-code-review.yml@c4820d6e62a9488c831e722aac202733fafab5dd
line 29: toolkit_ref: 96ef665ba04221de07e94fcc3ea69fe32c7cf306
claude-pr-metadata-update.yml:39 did move to c4820d6, which makes this the only pin left behind. Either bump it to match, or add a short comment recording that the older assets are intentional.
| uses: Uniswap/ai-toolkit/.github/workflows/_claude-code-review.yml@9b405c71e42d0cec4026f2c158edf99716600baa | |
| toolkit_ref: c4820d6e62a9488c831e722aac202733fafab5dd |
| custom_prompt_path: '.claude/prompts/claude-pr-review.md' | ||
|
|
||
| model: 'claude-opus-4-6' | ||
| model: 'claude-opus-5' |
There was a problem hiding this comment.
Dropping custom_prompt_path leaves .claude/prompts/claude-pr-review.md (182 lines of repo-specific review guidance) orphaned in the tree — nothing references it anymore, and reviews now use the toolkit default prompt. Delete that file as part of this PR, or keep the input if the custom guidance was still intended to apply.
There was a problem hiding this comment.
Still unresolved. custom_prompt_path remains removed and .claude/prompts/claude-pr-review.md (5.7 KB) is still present with no references anywhere:
$ grep -rn "claude-pr-review.md|custom_prompt_path" .github/ .claude/
(no matches)
Reviews are running on the toolkit default prompt while the repo-specific prompt sits orphaned in the tree. Delete the file, or restore the input if that guidance was still intended to apply.
|
Refreshed pin to |
Superseded by new review after PR update
There was a problem hiding this comment.
📋 Review verdict: COMMENT
👆 The main review comment above is the source of truth for this PR review. It is automatically updated on each review cycle, so always refer to it for the most current feedback.
This formal review submission is for the verdict only.
Summary
Maintenance pass on Claude Code Action workflows. Applies three classes of edit atomically:
v1.0.133(787c5a0) — see https://github.com/anthropics/claude-code-action/releases/tag/v1.0.13327e7e2d(Uniswap/ai-toolkitnextHEAD)haiku→claude-haiku-4-5-20251001opus→claude-opus-4-8sonnet→claude-sonnet-4-6Per-file changes
.github/workflows/claude-code-review.ymlUniswap/ai-toolkit/.github/workflows/_claude-code-review.yml:96ef665→27e7e2dcustom_prompt_path(no longer in Uniswap/ai-toolkit/.github/workflows/_claude-code-review.yml at the new SHA)claude-opus-4-6→claude-opus-4-8.github/workflows/claude-pr-metadata-update.ymlUniswap/ai-toolkit/.github/workflows/_generate-pr-metadata.yml:96ef665→27e7e2dOpened by the
sync-claude-code-actionmaintenance job. The job runs weekly and bumps SHAs + applies known migrations; review the diff before merging.AI-Generated Description
Summary
Maintenance pass on the Claude Code Action caller workflows. Bumps the pinned
Uniswap/ai-toolkitreusable-workflow SHA, bumps the review model, and drops an input that no longer exists in the reusable at the new SHA.96ef665→c4820d6claude-opus-4-6→claude-opus-5Per-file changes
.github/workflows/claude-code-review.ymluses: Uniswap/ai-toolkit/.github/workflows/_claude-code-review.yml:96ef665→c4820d6custom_prompt_path: '.claude/prompts/claude-pr-review.md'(no longer accepted by the reusable at the new SHA)claude-opus-4-6→claude-opus-5.github/workflows/claude-pr-metadata-update.ymluses: Uniswap/ai-toolkit/.github/workflows/_generate-pr-metadata.yml:96ef665→c4820d6Notes for reviewers
toolkit_refwas not bumped in lockstep. Inclaude-code-review.yml,uses:now points atc4820d6buttoolkit_ref:remains96ef665. The reusable usestoolkit_refto fetch supporting scripts at runtime, so this leaves a cross-version skew between the workflow body and its scripts. fix(ci): bump ai-toolkit reusable workflows past #453 RCE hardening #479 bumped both together on purpose — confirm this skew is intended before merging..claude/prompts/claude-pr-review.mdstill exists in the repo but is no longer referenced now thatcustom_prompt_pathis dropped. It can likely be removed in a follow-up if the reusable no longer supports a custom review prompt.Opened by the
sync-claude-code-actionmaintenance job. The job runs weekly and bumps SHAs + applies known migrations; review the diff before merging.