Skip to content

chore(deps): maintain Claude Code Action workflows (cca=v1.0.185, ait=c4820d6) #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wkoutre wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −5
Open

chore(deps): maintain Claude Code Action workflows (cca=v1.0.185, ait=c4820d6) #488

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
151beb5
chore(deps): maintain Claude Code Action workflows (cca=v1.0.133, ait…
wkoutre Jun 1, 2026
d699f71
chore(deps): maintain Claude Code Action workflows (cca=v1.0.183, ait…
wkoutre Aug 3, 2026
a442409
chore(deps): maintain Claude Code Action workflows (cca=v1.0.185, ait…
wkoutre Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/claude-code-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,13 @@ jobs:
github.event.action == 'ready_for_review'
)

uses: Uniswap/ai-toolkit/.github/workflows/_claude-code-review.yml@96ef665ba04221de07e94fcc3ea69fe32c7cf306
uses: Uniswap/ai-toolkit/.github/workflows/_claude-code-review.yml@9b405c71e42d0cec4026f2c158edf99716600baa

@github-actions github-actions Bot Aug 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The uses: pin moves to 9b405c7, but toolkit_ref just below (line 29) stays on 96ef665. That means the reusable workflow executes at the new revision while checking out toolkit assets from the old one.

That's a legitimate configuration, but since every other pin in this PR moved in lockstep it looks unintentional. If this is a full bump, update toolkit_ref too; if the older assets are needed on purpose, add a brief comment so the next maintenance pass doesn't change it blindly.

Suggested change
uses: Uniswap/ai-toolkit/.github/workflows/_claude-code-review.yml@9b405c71e42d0cec4026f2c158edf99716600baa
uses: Uniswap/ai-toolkit/.github/workflows/_claude-code-review.yml@9b405c71e42d0cec4026f2c158edf99716600baa
with:
pr_number: ${{ github.event.pull_request.number }}
base_ref: ${{ github.base_ref }}
force_review: false
toolkit_ref: 9b405c71e42d0cec4026f2c158edf99716600baa

@github-actions github-actions Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still unresolved on the current head. The pin has since moved from 9b405c7 to c4820d6, but toolkit_ref on line 29 is still 96ef665, so the mismatch I originally flagged is unchanged:

line 24:  uses: ..._claude-code-review.yml@c4820d6e62a9488c831e722aac202733fafab5dd
line 29:  toolkit_ref: 96ef665ba04221de07e94fcc3ea69fe32c7cf306

claude-pr-metadata-update.yml:39 did move to c4820d6, which makes this the only pin left behind. Either bump it to match, or add a short comment recording that the older assets are intentional.

Suggested change
uses: Uniswap/ai-toolkit/.github/workflows/_claude-code-review.yml@9b405c71e42d0cec4026f2c158edf99716600baa
toolkit_ref: c4820d6e62a9488c831e722aac202733fafab5dd

with:
pr_number: ${{ github.event.pull_request.number }}
base_ref: ${{ github.base_ref }}
force_review: false
toolkit_ref: 96ef665ba04221de07e94fcc3ea69fe32c7cf306
custom_prompt_path: '.claude/prompts/claude-pr-review.md'

model: 'claude-opus-4-6'
model: 'claude-opus-5'

@github-actions github-actions Bot Aug 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping custom_prompt_path leaves .claude/prompts/claude-pr-review.md (182 lines of repo-specific review guidance) orphaned in the tree — nothing references it anymore, and reviews now use the toolkit default prompt. Delete that file as part of this PR, or keep the input if the custom guidance was still intended to apply.

@github-actions github-actions Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still unresolved. custom_prompt_path remains removed and .claude/prompts/claude-pr-review.md (5.7 KB) is still present with no references anywhere:

$ grep -rn "claude-pr-review.md|custom_prompt_path" .github/ .claude/
(no matches)

Reviews are running on the toolkit default prompt while the repo-specific prompt sits orphaned in the tree. Delete the file, or restore the input if that guidance was still intended to apply.


# Standard timeout for most PRs
timeout_minutes: 20
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/claude-pr-metadata-update.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
!contains(github.head_ref, 'release/') &&
!startsWith(github.event.pull_request.title, 'chore(release):')

uses: Uniswap/ai-toolkit/.github/workflows/_generate-pr-metadata.yml@96ef665ba04221de07e94fcc3ea69fe32c7cf306
uses: Uniswap/ai-toolkit/.github/workflows/_generate-pr-metadata.yml@9b405c71e42d0cec4026f2c158edf99716600baa
with:
generation_mode: "description,deferred-title"
pr_number: ${{ github.event.pull_request.number }}
Expand Down
Loading