Add msgSender() to V4Quoter
#458
Open
+48
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
reviewed
Apr 2, 2025
src/lens/V4Quoter.sol
Outdated
| return Locker.get(); | ||
| } | ||
|
|
||
| modifier setMsgSender() { |
There was a problem hiding this comment.
can you move this definition above the functions?
hensha256
reviewed
Apr 24, 2025
Co-authored-by: Alice <[email protected]>
snreynolds
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
There's a growing subset of hooks which read the "wallet" of the swapper (or position creator). These hooks normally use the
msgSender()view function exposed by Universal Router and PosM, and can facilitate transactions without failureHowever,
msgSender()was not available on V4Quoter, causing reverts/failures when using the quoter against a hook'd pool readingmsgSender()Description of changes
Add
msgSender() external view returns (address)to V4Quoter.sol via transient storageAdd
IMsgSenderand added inheritance to IV4Quoter, BaseActionsRouter