Generically expose URDF joint dynamics.#56
Open
danzimmerman wants to merge 16 commits intoUniversalRobots:rollingfrom
Open
Generically expose URDF joint dynamics.#56danzimmerman wants to merge 16 commits intoUniversalRobots:rollingfrom
danzimmerman wants to merge 16 commits intoUniversalRobots:rollingfrom
Conversation
Icon45
reviewed
May 6, 2023
Icon45
left a comment
Icon45
left a comment
There was a problem hiding this comment.
I think it should be fine. But as I'm not an expert, I don't see myself in a position to approve the commit.
added 2 commits
May 6, 2023 15:52
…alRobots/Universal_Robots_ROS2_Description into dz/expose-joint-dyn-prop-file
…nzimmerman/Universal_Robots_ROS2_Description into dz/expose-joint-dyn-prop-file
Author
|
This should likely wait and build on top of #59 or equivalent. |
This was referenced May 9, 2023
Open
fmauch
reviewed
Sep 5, 2024
| </xacro:macro> | ||
|
|
||
| <xacro:macro name="read_model_data" params="joint_limits_parameters_file kinematics_parameters_file physical_parameters_file visual_parameters_file force_abs_paths"> | ||
| <xacro:macro name="read_model_data" params="joint_limits_parameters_file kinematics_parameters_file physical_parameters_file visual_parameters_file joint_dynamics force_abs_paths"> |
Contributor
There was a problem hiding this comment.
I think I would prefer passing the filename down to here as we do with the other parameters, as well.
Contributor
There was a problem hiding this comment.
Actually, I am not sure. It would be nicer to keep it on one level, however this way it is backwards compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is aimed at simulation use cases like #54 and #55, where simulation needs dictate different non-zero joint dynamics parameters.
In
ur.urdf.xacroI provide an example loading the joint dynamics properties from a config file, but followed the treatment ofinitial_positionsso that no config file is necessary to use thexacro:ur_robotmacro in other contexts.For the Gazebo Classic use case, I want to compute the dynamics parameters dynamically from other data, setting the joints'
frictionattributes to a multiple of the joints' effort limits like here.(See discussion in #55 and Universal_Robots_ROS2_Gazebo_Simulation/#19 for context.)
In other user code including
ur_macro.xacroI think this should not require any changes.