Feature/add solution updater patience #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
Hevagog
reviewed
Apr 14, 2025
src/services/solution_updater_service/core/service/solution_updater_service.py
Outdated
Show resolved
Hide resolved
dJaniga
requested changes
Apr 14, 2025
Collaborator
dJaniga
left a comment
dJaniga
left a comment
There was a problem hiding this comment.
Thanks Marcin for doing this implementation!
There are some suggestion which in my option will improve code readability and maintenance. Let's have discussion and challenge my point of view :)
src/orchestration/risk_management_service/core/service/risk_management_service.py
Show resolved
Hide resolved
src/services/solution_updater_service/core/service/solution_updater_service.py
Outdated
Show resolved
Hide resolved
src/orchestration/risk_management_service/core/service/risk_management_service.py
Outdated
Show resolved
Hide resolved
src/orchestration/risk_management_service/core/service/risk_management_service.py
Outdated
Show resolved
Hide resolved
src/services/solution_updater_service/core/service/solution_updater_service.py
Outdated
Show resolved
Hide resolved
src/services/solution_updater_service/core/service/solution_updater_service.py
Outdated
Show resolved
Hide resolved
dJaniga
reviewed
Apr 25, 2025
src/services/solution_updater_service/core/service/solution_updater_service.py
Show resolved
Hide resolved
dJaniga
approved these changes
Apr 25, 2025
Collaborator
dJaniga
left a comment
dJaniga
left a comment
There was a problem hiding this comment.
@MarcinStolarczyk01 2 small comments and ready to go :)
src/services/solution_updater_service/core/service/solution_updater_service.py
Outdated
Show resolved
Hide resolved
Introduced the `patience` parameter in `SolutionUpdaterService` and associated tests to enhance optimization control. Replaced unnecessary convergence check logic and ensured proper comparison handling for `None` values in the optimization loop. This improves flexibility and robustness of the solution updater process.
Hevagog
reviewed
Apr 25, 2025
src/services/solution_updater_service/core/service/solution_updater_service.py
Show resolved
Hide resolved
src/services/solution_updater_service/core/service/solution_updater_service.py
Show resolved
Hide resolved
src/services/solution_updater_service/core/service/solution_updater_service.py
Show resolved
Hide resolved
src/services/solution_updater_service/core/service/solution_updater_service.py
Outdated
Show resolved
Hide resolved
src/services/solution_updater_service/core/service/solution_updater_service.py
Show resolved
Hide resolved
Hevagog
approved these changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add patience parameter to stop optimization after stagnation
Description
This PR extends SolutionUpdater by a "patience" parameter which defines how many iterations with the same best results in a row will stop optimization loop.
Type of Change:
Issue Solution updater should terminate when candidates converge to value and stale for P iteration #25
How Has This Been Tested?
Describe the tests that you ran to verify your changes. Include details on the testing environment, test cases, and any relevant configurations. If applicable, provide steps to reproduce the testing process.
We encourage you to keep the code coverage percentage at 90% and above.
have not been included
Testing Environment:
If your PR includes UI changes or modifications to the command-line interface (CLI), provide before and after screenshots.
Checklist
Ensure that all the following tasks are completed before submitting your PR:
requirements.txtorpyproject.tomlhas been updated accordingly.