Conversation
Co-authored-by: Yuto Ashida <y-chan@y-chan.dev>
Hiroshiba
left a comment
There was a problem hiding this comment.
LGTM!!
設定する方針、良いと思います!!
ヌケモレすることによるテスト発見遅れがあるかもだけど、テストが回りまくるよりはマシそう。
AI君に漏れがないか検査してもらうと少し安心できるかもですね!
頼りないけどcopilot君にもレビュー頼んでみます。あとcodex君も頼ってみよう。
|
@codex レビューしてください。 |
|
To use Codex here, create a Codex account and connect to github. |
There was a problem hiding this comment.
Pull request overview
This PR adds paths filters to the on.pull_request triggers in three GitHub Actions workflow files to optimize CI execution by only running workflows when relevant files are changed. This is based on issue #382 and adapted to the current repository structure. The .github/ directory is specified as .github/** to avoid missing any relevant changes.
- Added path filters to
test.ymlworkflow - Added path filters to
generate_document.ymlworkflow - Added path filters to
build_and_deploy.ymlworkflow
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/test.yml | Added paths filter to trigger tests only when Rust code, cargo config, examples, models, or GitHub workflow files change |
| .github/workflows/generate_document.yml | Added paths filter to trigger documentation generation only when core code, documentation files, or related configurations change |
| .github/workflows/build_and_deploy.yml | Added paths filter to trigger build/deploy only when core code, build utilities, models, or related configurations change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
#1272 で得られた気付きをもとに、足りてなかったと思われるパターンを埋め る。
内容
#382 で書かれたものをベースに、今のこのリポジトリに沿うようにする。
.github/以下については漏れが怖いので、一括で
.github/**という形の指定にする。既存のon.pull_request.pathにも問題がある気がするが、あったとしても別PRでやることにする。その他