check_equal support for fixed_pkg resolve #909#989
Merged
LarsAsplund merged 2 commits intoVUnit:masterfrom Mar 10, 2024
Merged
Conversation
|
I'm not an expert in VUnits code, but this looks quite good. About the string representation, I think since |
46cb966 to
62533c0
Compare
62533c0 to
f22ef02
Compare
Member
|
After updating license copyright years and running black, the remaining CI errors are related to the code in this PR. Check the following format mismatch: |
Set a format style for `to_string(real)` so that we get a consistent string format for each simulator. Format now defaults to `"%f"`.
Contributor
Author
|
It seems that every simulator had a slightly different default format for the |
Member
|
See #997. |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How do you want to handle the string representation of fixed_pkg types? I used the
to_stringfunction from the fixed_pkg. Do you prefer theto_nibble_stringstyle or a merge of both styles?