Use List.Sort for ordered dictionary output - #345
Merged
Conversation
Replace the local iterator + LINQ OrderBy with building a List<DictionaryEntry> and sorting it in-place before serialization. For string keys the list is sorted with StringComparer.OrdinalIgnoreCase, otherwise with Comparer.Default, and then each entry is serialized. This simplifies the code, removes the static Items iterator, and reduces allocation/iteration overhead when serializing ordered dictionaries.
SimonCropp
added a commit
that referenced
this pull request
Feb 8, 2026
This reverts commit 852a492.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the local iterator + LINQ OrderBy with building a List and sorting it in-place before serialization. For string keys the list is sorted with StringComparer.OrdinalIgnoreCase, otherwise with Comparer.Default, and then each entry is serialized. This simplifies the code, removes the static Items iterator, and reduces allocation/iteration overhead when serializing ordered dictionaries.