Skip to content

Use List.Sort for ordered dictionary output #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 1 commit into from
Feb 7, 2026
Merged

Use List.Sort for ordered dictionary output #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions src/Argon/Serialization/JsonSerializerInternalWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,29 +896,26 @@ void SerializeDictionary(JsonWriter writer, IDictionary values, JsonDictionaryCo

var keyContract = contract.KeyContract ??= Serializer.ContractResolver.ResolveContract(contract.DictionaryKeyType ?? typeof(object));

static IEnumerable<DictionaryEntry> Items(IDictionary values)
if (contract is {OrderByKey: true, IsSortable: true})
{
var entries = new List<DictionaryEntry>();
foreach (DictionaryEntry entry in values)
{
yield return entry;
entries.Add(entry);
}
}

if (contract is {OrderByKey: true, IsSortable: true})
{
if (contract.DictionaryKeyType == typeof(string))
{
foreach (var entry in Items(values).OrderBy(_ => ((string) _.Key, StringComparer.OrdinalIgnoreCase)))
{
SerializeDictionaryItem(writer, contract, member, entry.Key, entry.Value, keyContract, underlying);
}
entries.Sort((a, b) => StringComparer.OrdinalIgnoreCase.Compare((string) a.Key, (string) b.Key));
}
else
{
foreach (var entry in Items(values).OrderBy(_ => _.Key))
{
SerializeDictionaryItem(writer, contract, member, entry.Key, entry.Value, keyContract, underlying);
}
entries.Sort((a, b) => Comparer.Default.Compare(a.Key, b.Key));
}

foreach (var entry in entries)
{
SerializeDictionaryItem(writer, contract, member, entry.Key, entry.Value, keyContract, underlying);
}
}
else
Expand Down