Fix cloning did not correctly apply all previous values #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
I was wrong, but anyway there is a weird case to handle in admin... |
shavounet
force-pushed
the
fix-cdm-cloning
branch
from
81914fa to
5c90bb8
Compare
Contributor
Author
I've rollback my change on cloning embedded entities, though there's still an issue to handle because there is no id for cloned embedded entities and twig do not handle this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
With a full CDM, using a "clone" action on an entity (with possibly embedded data) did not copied all values (only a subset...).
Solution
Still not sure why it works, but using
\Sidus\EAVModelBundle\Entity\AbstractData::addValuehelped...After this change there was a second error in admin, from a twig template
vendor/cleverage/eav-manager/LayoutBundle/Resources/views/Form/form.fields.html.twig:184, because the embedded data did not have an id. I removed the "clone embedded data" behaviour from\Sidus\EAVModelBundle\Entity\AbstractValue::__clonebecauseThis last change could be a breaking one.