fix: paste into Firefox through clipboard fallback - #425
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
==========================================
- Coverage 79.91% 79.76% -0.15%
==========================================
Files 30 30
Lines 4615 4661 +46
Branches 699 709 +10
==========================================
+ Hits 3688 3718 +30
- Misses 779 790 +11
- Partials 148 153 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @juanfradb, closing this. Thanks for the Firefox report, but I don't want this patch to land. #665 did not fix Firefox ignoring IBus. That PR restores the XKB layout after scoped injection. A few problems with the approach:
Draft, untouched since May, and it conflicts with current If Firefox-on-X11 still silently drops IBus commits, the right knobs are already in flight: pin a non-IBus backend ( |
Summary
xdotool key ctrl+vfor Firefox instead of direct IBus commitWhy
Firefox text fields can ignore IBus commit text in some X11 desktop setups even while terminal and other applications work. Clipboard paste is the reliable path there and already matches the existing clipboard fallback model.
Impact
Firefox users get the dictated text inserted instead of silently losing it. The recognized text is copied to clipboard as part of the paste fallback.
Validation
PYTHONPATH=src /home/juanfra/.local/share/vocalinux/venv/bin/python -m pytest tests/test_text_injector.py -qPYTHONPATH=src /home/juanfra/.local/share/vocalinux/venv/bin/python -m py_compile src/vocalinux/text_injection/text_injector.py tests/test_text_injector.pyblack --checkon changed files