Add Conversion Functions between Typical Sensor Msgs and our Tensor#16
Merged
thomasonzhou merged 8 commits intomainfrom Sep 23, 2025
Merged
Add Conversion Functions between Typical Sensor Msgs and our Tensor#16thomasonzhou merged 8 commits intomainfrom
thomasonzhou merged 8 commits intomainfrom
Conversation
thomasonzhou
requested changes
Sep 23, 2025
Contributor
thomasonzhou
left a comment
thomasonzhou
left a comment
There was a problem hiding this comment.
Added some comments, serious question about managing the encoding
Since the encoding is technically fixed until reencoded shouldn't this be attached to the tensor? The underlying dtype can stay as another property. However, I'm not sure if everyone would use this (might be unnecessary complexity)
Contributor
Author
|
@thomasonzhou #19 issue to onnx handling type conversions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds in type conversion headers between various ROS2 sensor msgs and our Tensor type.