-
Notifications
You must be signed in to change notification settings - Fork 5
feat(prediction): implement module skeleton with multi-modal architec… #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Edwardius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! things are skeleton state atm so im not going to review too heavily. careful about ai generated slop, usually it tends to make unnessesary comments (ie. comments of things being removed, if it doesn't exist, why comment about it?)
As for architecture, it seems sane on paper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use yaml launchfile format instead please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean converting the Python launch file to XML format?
📑 Description
This PR implements the foundational skeleton for the prediction module within the world_modeling stack. It establishes the core node architecture and defines the necessary interfaces for multi-modal trajectory prediction (Vehicle, Pedestrian, Cyclist).
This structure is needed to:
📹 (Optional) Video Demo of Changes
✅ Checklist
🔗 Related Issues / PRs
📝 Notes for reviewers