Cell - Enable modem#303
Open
halyssonJr wants to merge 1 commit into
Open
Conversation
| /// <summary> | ||
| /// Type of Cell Modem. | ||
| /// </summary> | ||
| public enum CellModemType |
Contributor
There was a problem hiding this comment.
This feels like it belongs in Meadow.Foundation not contracts
| string FetchGnssAtCmdsOutput(IGnssResult[] resultTypes, int timeout = gnssFixTimeoutInSeconds); | ||
|
|
||
| /// <summary> | ||
| /// Enable the modem to communicate through serial (COM1 or COM4). |
Contributor
There was a problem hiding this comment.
I don't think we need to specify the comm port in the comment since it's an interface
| /// </summary> | ||
| /// <param name="pin"> Output pin connected to PWRKEY.</param> | ||
| /// <param name="modem">The type of modem model ported. </param> | ||
| public void EnableModem(IPin pin, CellModemType modem); |
Contributor
There was a problem hiding this comment.
Is this universal or potentially hardware-specific? again, feels like Meadow.Foundation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PR aims to add an enumeration to different kinds of cell modems.