-
Notifications
You must be signed in to change notification settings - Fork 11
Cell - Enable modem #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Cell - Enable modem #303
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| namespace Meadow; | ||
|
|
||
| /// <summary> | ||
| /// Type of Cell Modem. | ||
| /// </summary> | ||
| public enum CellModemType | ||
| { | ||
| /// <summary> | ||
| /// LTE cell modem BG95 manufactured by Quectel | ||
| /// </summary> | ||
| Bg95, | ||
| /// <summary> | ||
| /// GSM cell modem M95 manufactured by Quectel | ||
| /// </summary> | ||
| M95, | ||
| /// <summary> | ||
| /// LTE cell modem EG21BL manufactured by Quectel | ||
| /// </summary> | ||
| Eg21gl, | ||
| }; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -61,4 +61,11 @@ public interface ICellNetworkAdapter : INetworkAdapter | |
| /// <param name="timeout">The GNSS scan timeout duration in seconds.</param> | ||
| /// <returns>A string containing combined output from GNSS-related AT commands, including NMEA sentences.</returns> | ||
| string FetchGnssAtCmdsOutput(IGnssResult[] resultTypes, int timeout = gnssFixTimeoutInSeconds); | ||
|
|
||
| /// <summary> | ||
| /// Enable the modem to communicate through serial (COM1 or COM4). | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we need to specify the comm port in the comment since it's an interface |
||
| /// </summary> | ||
| /// <param name="pin"> Output pin connected to PWRKEY.</param> | ||
| /// <param name="modem">The type of modem model ported. </param> | ||
| public void EnableModem(IPin pin, CellModemType modem); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this universal or potentially hardware-specific? again, feels like Meadow.Foundation |
||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like it belongs in Meadow.Foundation not contracts