Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions Source/Meadow.Contracts/Enums/CellModemType.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
namespace Meadow;

/// <summary>
/// Type of Cell Modem.
/// </summary>
public enum CellModemType

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it belongs in Meadow.Foundation not contracts

{
/// <summary>
/// LTE cell modem BG95 manufactured by Quectel
/// </summary>
Bg95,
/// <summary>
/// GSM cell modem M95 manufactured by Quectel
/// </summary>
M95,
/// <summary>
/// LTE cell modem EG21BL manufactured by Quectel
/// </summary>
Eg21gl,
};
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,11 @@ public interface ICellNetworkAdapter : INetworkAdapter
/// <param name="timeout">The GNSS scan timeout duration in seconds.</param>
/// <returns>A string containing combined output from GNSS-related AT commands, including NMEA sentences.</returns>
string FetchGnssAtCmdsOutput(IGnssResult[] resultTypes, int timeout = gnssFixTimeoutInSeconds);

/// <summary>
/// Enable the modem to communicate through serial (COM1 or COM4).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to specify the comm port in the comment since it's an interface

/// </summary>
/// <param name="pin"> Output pin connected to PWRKEY.</param>
/// <param name="modem">The type of modem model ported. </param>
public void EnableModem(IPin pin, CellModemType modem);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this universal or potentially hardware-specific? again, feels like Meadow.Foundation

}
Loading