feat: French Language Support - #240
Merged
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
Thank you for your contribution! No worries on the spec, it was an easy fix. Will merge it as it stands |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding initial support for French language.
I attempted to follow the existing paradigms in place as best I could. Net new locale files added for "fr" code, with fallbacks to English. I suspect i18n-utils.spec could be updated at line 34 to negotiate browser language to French as well, but I'm very new to the Go + JS space so I was keeping any changes as minimal as possible. CI checks passed locally, and local testing looked as expected.
When/if this PR moves upstream, it will be easier to find support on my side around official translator review.