Notes: Compute note positions centrally in useFloatingBoard#77433
Merged
Notes: Compute note positions centrally in useFloatingBoard#77433
Conversation
Mamaduka
added
[Type] Enhancement
6 tasks
Mamaduka
commented
Apr 16, 2026
|
Size Change: -6.61 kB (-0.09%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in e6f0dbc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24706118999
|
Mamaduka
force-pushed
the
try/notes-unified-positions-system
branch
from
11ed1b0 to
de455eb
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
reviewed
Apr 17, 2026
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Great enhancements! I noticed the following two points, but can these be addressed?
There is no space at the end of the note:
When I create a new line in the last note, it scrolls up:
Recording.2026-04-17.160949.mp4
Member
Author
|
Thanks, @t-hamano! I'll have a look later today, I think both issues should be fixable. |
Mamaduka
force-pushed
the
try/notes-unified-positions-system
branch
from
de455eb to
4c21db0
Compare
Member
Author
|
@t-hamano, I think I managed to fix both problems. Plus, during iterations, Cloud and I found an interesting solution, which requires fewer hacks. |
Mamaduka
force-pushed
the
try/notes-unified-positions-system
branch
from
4c21db0 to
5e78743
Compare
Mamaduka
force-pushed
the
try/notes-unified-positions-system
branch
from
5e78743 to
e976584
Compare
t-hamano
approved these changes
Apr 21, 2026
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! Works as expected 👍
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #73653.
Partially solves #73565.
Replaces the floating-UI
autoUpdatedependency with a CSS-driven scroll-sync approach. Note positions are computed once in canvas content-space; a single CSS custom property (--canvas-scroll) on the sidebar panel drives the visual sync on every scroll event.@floating-ui/domfrom@wordpress/editordependencies.canvasMinHeighteditor state (action, selector, reducer). The canvas no longer grows to fit the sidebar.blockRect.top + scrollTop(the block's absolute y within the editor's scroll content).-canvas.scrollTopinto--canvas-scrollon the panel. CSS inherits the variable and each floating thread appliestransform: translateY(var(--canvas-scroll))..is-root-containerso nested-block scroll containers (e.g. a Group withoverflow: auto) don't shadow the editor canvas.Why?
Testing Instructions
Stress test floating notes.
Testing Instructions for Keyboard
Same.
Use of AI Tools
Used Claude to brainstorm my ideas, tested and reviewed personally.